Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: vue sorting controlled #4961

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

radusuciu
Copy link
Contributor

This is based on the vue controlled pagination example which might have some issues as noted in #4956.

One thing was unclear to me. When setting the state property that is passed to the useVueTable composable, here is what I'm doing in this example:

  state: {
    pagination: pagination.value,
    get sorting() {
      return sorting.value
    },
  },

this did not work:

  state: {
    pagination: pagination.value,
    sorting: sorting.value
  },

and I'm not entirely sure why. Though based on other issues/discussions/comments from vue users of this library, I think I'm not alone in being a little confused about the use of getters in dealing with table state and data.

@radusuciu radusuciu force-pushed the feat-vue-sorting-controlled branch from eeaf7ff to 84c02af Compare July 11, 2023 20:29
@radusuciu radusuciu changed the title feat: vue sorting controlled example examples: vue sorting controlled Jul 11, 2023
@KevinVandy KevinVandy merged commit 465426a into TanStack:main Jul 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants