Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add test connection button #3345

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat(ui): add test connection button #3345

wants to merge 12 commits into from
+137 −38

Conversation

liangfung
Copy link
Collaborator

@liangfung liangfung commented Oct 31, 2024 •
edited
Loading

Screen record

https://jam.dev/c/cfccd620-93ae-4f02-be4a-fa4410fbd261

Screenshot

Unreachable

image

@liangfung liangfung marked this pull request as ready for review October 31, 2024 10:11
wsxiaoys
wsxiaoys reviewed Oct 31, 2024
View reviewed changes
ee/tabby-ui/app/(dashboard)/system/components/worker-card.tsx Outdated
disabled={fetching}
onClick={reexecuteQuery}
>
<IconRefresh className="h-3.5 w-3.5" />
Copy link
Member

@wsxiaoys wsxiaoys Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<IconRefresh className="h-3.5 w-3.5" />
<IconRefresh className="h-3.5 w-3.5" />

Use radix reload: https://www.radix-ui.com/icons

image

@wsxiaoys
Copy link
Member

Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsxiaoys wsxiaoys wsxiaoys requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangfung @wsxiaoys