Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic to fetch soon starting streams #1417

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

carlobortolan
Copy link
Member

@carlobortolan carlobortolan commented Nov 29, 2024

Motivation and Context

Currently, if a professor has two lectures planned directly after each other, there could be conflicts about which stream to choose. E.g., If there's one lecture from 2-4 p.m. and one from 4-6 p.m. and the professor starts streaming at 3:59 p.m., the first lecture is selected. However, if the professor starts at 4 or 4:01 p.m., one might expect the second one to be selected, but it still selects the first one, as there's a buffer of 15 minutes before/after each lecture.

Description

  • Updated GetSoonStartingStream method to consider the case when two lectures from the same professors start right after each other.
  • Fix typo in token tab
  • Update self-streaming guide links to redirect to the new documentation page
  • Update go.work.sum file
  • Disable self-streams using rtmp-proxy (see Test courses for lecturers #1418)

Steps for Testing

  • Log in using a lecturer account and go to the admin tab

Screenshots

image

@carlobortolan carlobortolan self-assigned this Nov 29, 2024
Copy link

Your Testserver will be ready at https://1417.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@carlobortolan carlobortolan linked an issue Dec 3, 2024 that may be closed by this pull request
@carlobortolan carlobortolan added bug Something isn't working documentation Improvements or additions to documentation Open Source Lab labels Dec 10, 2024
@carlobortolan carlobortolan marked this pull request as ready for review December 10, 2024 12:39
@carlobortolan carlobortolan requested a review from a team December 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation Open Source Lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant