Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starr-anime): French Anime guide + fixes #2135

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

SeiyaGame
Copy link
Contributor

@SeiyaGame SeiyaGame commented Nov 20, 2024

Pull Request

Purpose

Initial draft of the new french anime guide

Requirements

TODO / Done

  • Add French Anime Tier
  • Add Anime Score for French Tier
  • Add repack for sonarr anime (Same as v1, v2, v3 ...)
  • Add anime part in French Radarr Guide
  • Add FR Anime Tier to the Collection List
  • Remove T3KASHi from FR HD Bluray Tier 01, FR WEB Tier 01 to avoid double scoring, already in FR Anime Tier 01
  • Remove FUJiSAN from FR HD Bluray Tier 02, FR WEB Tier 02 to avoid double scoring, already in FR Anime Tier 02
  • Remove HANAMi from FR HD Bluray Tier 02, FR WEB Tier 02 to avoid double scoring, already in FR Anime Tier 03
  • Testing on a Radarr anime instance (to validate the guide) (In progress)
  • Add quality settings file size for Anime ⚠️ MD5 is same for Sonarr
  • Add TIP for those who prefer fansub to official translations
  • Add MULTI CF in Language Profiles Related Custom Formats Scoring and tip info

@github-actions github-actions bot added Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Nov 20, 2024
@SeiyaGame
Copy link
Contributor Author

@TRaSH- I added the quality settings (file size) for Anime but the trash_id on Radarr and Sonarr his the same ...

MD5 of anime: 387e6278d8e06083d813358762e0ac63

Is it okay if I leave it like this? (I suppose not)

@bakerboy448 bakerboy448 added Status: Waiting for User Waiting for OP or Contributor to address feedback or provide information Do Not Merge Do Not Merge labels Dec 3, 2024
@github-actions github-actions bot added the Area: Sonarr Sonarr Related label Dec 18, 2024
@SeiyaGame SeiyaGame changed the title feat(Radarr-Anime): French Anime guide feat(starr-anime): French Anime guide + fixes Dec 18, 2024
@SeiyaGame
Copy link
Contributor Author

@TRaSH- I added the quality settings (file size) for Anime but the trash_id on Radarr and Sonarr his the same ...

MD5 of anime: 387e6278d8e06083d813358762e0ac63

Is it okay if I leave it like this? (I suppose not)

@TRaSH- Possible to have an feedback for this md5 conflict ? Thx

@bakerboy448
Copy link
Contributor

It should not be possible for a hash to conflict ever - all hash must be unique.

https://github.com/TRaSH-Guides/Guides/blob/master/CONTRIBUTING.md#hashcode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bakerboy448
As I said above the radarr quality size for the anime I added as same hashcode with the sonarr quality size for the anime
The error is on the sonarr side ?!

I followed the CONTRIBUTING.md guide

So normally it should look like this ?
Radarr : anime : 387e6278d8e06083d813358762e0ac63
Sonarr : Sonarr anime : eb5a5645713cc839ead82e77a0814389

Or currently this is :
Sonarr : anime : 387e6278d8e06083d813358762e0ac63

Code extraction of docs/json/sonarr/quality-size/anime.json

{
  "trash_id": "387e6278d8e06083d813358762e0ac63",
  "type": "anime",
  "qualities": [

Temporary I can set the hascode like this to avoid conflict :
Radarr anime : c2aa9540a57d273a9e03a538efe0ca1b

I don't really know what to do

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look tomorrow when I'm back home in time. Officially, they shouldn't have the same hashcode. If they do, then we need to fix it.

Result :
- Radarr Anime FR Anime FanSub : `eb1e434d8e46cb3f728c79f8e4400bfd`
- Radarr Anime FR Anime Tier 01: `03520acbc5e46ce326be984534792d28`
- Radarr Anime FR Anime Tier 02: `20393e1196752dc37b25b80dfd2f8f57`
- Radarr Anime FR Anime Tier 03: `9d2a63eda874b34e06e7a8cbea7ea639`
@github-actions github-actions bot added the Status: Conflicted Pull Request is Conflicted label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Do Not Merge Do Not Merge Status: Conflicted Pull Request is Conflicted Status: Waiting for User Waiting for OP or Contributor to address feedback or provide information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants