-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starr-anime): French Anime guide + fixes #2135
base: master
Are you sure you want to change the base?
feat(starr-anime): French Anime guide + fixes #2135
Conversation
Multiple time found certain tracker tag a release as repack/proper instead of v1, v2 etc They follow the scene naming scheme
- FR Scene Groups - VOSTFR
…oid double scoring
…oid double scoring
…id double scoring
@TRaSH- I added the quality settings (file size) for Anime but the MD5 of Is it okay if I leave it like this? (I suppose not) |
It should not be possible for a hash to conflict ever - all hash must be unique. https://github.com/TRaSH-Guides/Guides/blob/master/CONTRIBUTING.md#hashcode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bakerboy448
As I said above the radarr quality size for the anime I added as same hashcode with the sonarr quality size for the anime
The error is on the sonarr side ?!
I followed the CONTRIBUTING.md guide
So normally it should look like this ?
Radarr : anime
: 387e6278d8e06083d813358762e0ac63
Sonarr : Sonarr anime
: eb5a5645713cc839ead82e77a0814389
Or currently this is :
Sonarr : anime
: 387e6278d8e06083d813358762e0ac63
Code extraction of docs/json/sonarr/quality-size/anime.json
{
"trash_id": "387e6278d8e06083d813358762e0ac63",
"type": "anime",
"qualities": [
Temporary I can set the hascode like this to avoid conflict :
Radarr anime
: c2aa9540a57d273a9e03a538efe0ca1b
I don't really know what to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look tomorrow when I'm back home in time. Officially, they shouldn't have the same hashcode. If they do, then we need to fix it.
Result : - Radarr Anime FR Anime FanSub : `eb1e434d8e46cb3f728c79f8e4400bfd` - Radarr Anime FR Anime Tier 01: `03520acbc5e46ce326be984534792d28` - Radarr Anime FR Anime Tier 02: `20393e1196752dc37b25b80dfd2f8f57` - Radarr Anime FR Anime Tier 03: `9d2a63eda874b34e06e7a8cbea7ea639`
Pull Request
Purpose
Initial draft of the new french anime guide
Requirements
TODO / Done
T3KASHi
fromFR HD Bluray Tier 01
,FR WEB Tier 01
to avoid double scoring, already inFR Anime Tier 01
FUJiSAN
fromFR HD Bluray Tier 02
,FR WEB Tier 02
to avoid double scoring, already inFR Anime Tier 02
HANAMi
fromFR HD Bluray Tier 02
,FR WEB Tier 02
to avoid double scoring, already inFR Anime Tier 03
Language Profiles Related Custom Formats Scoring
and tip info