Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guide): unclear qbit mover script host vs url and added cache only #1923

Merged
merged 1 commit into from
May 15, 2024

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented May 8, 2024

Pull Request

Purpose

host => The URL you use to access qBittorrent locally. this says to use a URL which would be http://IP:PORT

Approach

  • replace ip with your unraid server ip, replace port with your webgui port you use to access the webgui
  • added switch to only pause torrents that are actually on your cache drive

Open Questions and Pre-Merge TODOs

Requirements

@github-actions github-actions bot added Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related labels May 8, 2024
@TRaSH- TRaSH- linked an issue May 8, 2024 that may be closed by this pull request
@TRaSH- TRaSH- requested a review from a team May 8, 2024 18:07
Copy link
Contributor

@nuxencs nuxencs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a bit more consistency with the upper and lowercase of Unraid 🤔

@TRaSH-
Copy link
Contributor Author

TRaSH- commented May 8, 2024

maybe a bit more consistency with the upper and lowercase of Unraid 🤔

It kinda sucks how it's used in general. Sometimes you see plain Unraid, other times they use unRaid. To be honest, I don't know what the official naming would be.

@zakkarry
Copy link
Contributor

zakkarry commented May 8, 2024

I used to always use unRAID, since RAID is an acronym and all caps are generally used for it....but their site uses Unraid mostly, with a few exceptions - mostly on their forums.

I don't think it really makes much difference, one versus the other, but I think we should try and be somewhat consistent. I like unRAID personally.

@nuxencs
Copy link
Contributor

nuxencs commented May 12, 2024

official naming seems to be Unraid.

@nuxencs nuxencs force-pushed the fix/guide-unclear-qbit-mover-script-host-vs-url branch from e337e83 to 270b438 Compare May 12, 2024 18:24
@TRaSH- TRaSH- force-pushed the fix/guide-unclear-qbit-mover-script-host-vs-url branch from 270b438 to c802adc Compare May 15, 2024 18:24
@TRaSH- TRaSH- requested a review from nuxencs May 15, 2024 18:26
Copy link
Contributor

@nuxencs nuxencs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TRaSH- TRaSH- merged commit 965750d into master May 15, 2024
9 checks passed
@TRaSH- TRaSH- deleted the fix/guide-unclear-qbit-mover-script-host-vs-url branch May 15, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Downloaders Downloaders Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] (Guide): unclear qbit mover script host vs url language
3 participants