Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sonarr): add 720p CF #1896

Merged
merged 1 commit into from
May 17, 2024
Merged

chore(sonarr): add 720p CF #1896

merged 1 commit into from
May 17, 2024

Conversation

dctr
Copy link
Contributor

@dctr dctr commented Apr 25, 2024

Pull Request

Purpose

Adding a 720p CF to sonarr.

Approach

This is following the 2160p and 1080p formats already available for Sonarr, plus the 2160p, 1080p and 720p formats for Radarr, to complete the set.

Hash created via https://md5.gromweb.com/?string=Sonarr+720p

Requirements

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Apr 25, 2024
@TRaSH-
Copy link
Contributor

TRaSH- commented Apr 28, 2024

Just curious why would we want a CF for this resolution?
Basically it wouldn't be needed being quality trump's all.
The only reason Radarr has it, is because of a special quality profile where it's needed for the 1080p and 2160p

@dctr
Copy link
Contributor Author

dctr commented Apr 28, 2024

Yes, I am doing something similar than SQP for my TV shows, in that I combine certain qualities into a single profile and want to use resolution as one of the factors by which I rank what release I want. I can of course add this manually, but having it as a TRaSH rule would make my usage of recyclarr much more consistent.

I thought this addition wouldn't be too controversial, given that sonarr already has the 1080p and 2160p rules. But if you feel it goes against the principles of your guides, of course feel free to close/reject this.

@TRaSH-
Copy link
Contributor

TRaSH- commented Apr 28, 2024

Seems we're also missing the 2160p in Sonarr, add that one also and i will accept it ;)

@dctr
Copy link
Contributor Author

dctr commented May 2, 2024

Will do, give me a few days, this week is pretty busy.

@TRaSH-
Copy link
Contributor

TRaSH- commented May 8, 2024

Will do, give me a few days, this week is pretty busy.

just a ping so you don't forget

@dctr
Copy link
Contributor Author

dctr commented May 9, 2024

@TRaSH- , there is already a 2160p file, no? 😅

https://github.com/TRaSH-Guides/Guides/blob/master/docs/json/sonarr/cf/2160p.json

@yammes08
Copy link
Contributor

Think this 720p CF also needs to be added to the Sonarr Collection of Custom Formats guide page.

@TRaSH-
Copy link
Contributor

TRaSH- commented May 15, 2024

Think this 720p CF also needs to be added to the Sonarr Collection of Custom Formats guide page.

we don't have the resolutions CF in the table, iirc not even in Radarr

Creating a 720p custom format for Sonarr.

This is following the 2160p and 1080p formats already available for Sonarr, plus the 2160p, 1080p and 720p formats for Radarr, to complete the set.

Hash created via https://md5.gromweb.com/?string=Sonarr+720p
@nuxencs nuxencs merged commit 0c4a869 into TRaSH-Guides:master May 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants