Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(guide): Update mkdocs.yml w/ copyright year #1893

Merged
merged 3 commits into from
May 15, 2024

Conversation

BernCarney
Copy link
Contributor

Just updating copyright year to be current year

Pull Request

Purpose

Quick change to update copyright year to be accurate.

Approach

Updated copyright value in mkdocs.yml which should cascade down.

Open Questions and Pre-Merge TODOs

Requirements

Just updating copyright year to be current year
@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Apr 23, 2024
@bakerboy448
Copy link
Contributor

please update the PR title per contribution guidelines

@BernCarney BernCarney changed the title Update mkdocs.yml w/ copyright year chore(guide) Update mkdocs.yml w/ copyright year Apr 23, 2024
@BernCarney BernCarney changed the title chore(guide) Update mkdocs.yml w/ copyright year chore(guide): Update mkdocs.yml w/ copyright year Apr 23, 2024
@TRaSH-
Copy link
Contributor

TRaSH- commented Apr 28, 2024

Thx I'll take a look at it when I wake up

@owine
Copy link
Contributor

owine commented Apr 28, 2024

Maybe the JS of <script>document.write(new Date().getFullYear())</script> would be better than the hardcoded date?

https://stackoverflow.com/questions/67983304/how-to-use-build-date-utc-for-copyright-year-in-mkdocs-yml

Dev also suggests using a mkdocs hook: squidfunk/mkdocs-material#4969 (reply in thread)

@BernCarney
Copy link
Contributor Author

Maybe the JS of <script>document.write(new Date().getFullYear())</script> would be better than the hardcoded date?

https://stackoverflow.com/questions/67983304/how-to-use-build-date-utc-for-copyright-year-in-mkdocs-yml

Dev also suggests using a mkdocs hook: squidfunk/mkdocs-material#4969 (reply in thread)

This could work but you would want a fallback anyways in case the user has javascript disabled. Copyright is one of those weird circumstances where I lean towards hard-coded and have some checks in a linter or pre-commit hook to make sure it matches the current year vs relying on something dynamic.

@FonduemangVI FonduemangVI self-requested a review May 15, 2024 10:16
@FonduemangVI FonduemangVI merged commit 1b19bf2 into TRaSH-Guides:master May 15, 2024
9 checks passed
Lokilicious pushed a commit to Lokilicious/Guides that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants