-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(guide): Starr language tips add German dual and multi #1880
feat(guide): Starr language tips add German dual and multi #1880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
probably a good idea to let @zakkarry proofread it 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only had one suggestion for a block, didn't check anything besides grammar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline for admonition per mkdocs documentation
aecef99
to
a8673d8
Compare
Co-authored-by: zakary <[email protected]>
Co-authored-by: zakary <[email protected]>
Co-authored-by: nuxen <[email protected]>
4bfb39d
to
41bf284
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…des#1880) * feat(guide): Starr language tips add German dual and multi * fixed: url redirect failure * Apply suggestions from code review Co-authored-by: zakary <[email protected]> * Update docs/Radarr/Tips/How-to-setup-language-custom-formats.md Co-authored-by: zakary <[email protected]> * Apply suggestions from code review Co-authored-by: nuxen <[email protected]> --------- Co-authored-by: zakary <[email protected]> Co-authored-by: nuxen <[email protected]>
Pull Request
Purpose
Dual and Multi language is also picked up as original audio, for some users it's a preferred option, others rather don't get those releases because there is no way to determine upfront which audio track is used as main audio track.
Approach
Open Questions and Pre-Merge TODOs
Requirements