Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide): Starr language tips add German dual and multi #1880

Merged

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented Apr 13, 2024

Pull Request

Purpose

Dual and Multi language is also picked up as original audio, for some users it's a preferred option, others rather don't get those releases because there is no way to determine upfront which audio track is used as main audio track.

Approach

Open Questions and Pre-Merge TODOs

  • Added a Custom Format provided by @mynameisbogdan that matches on German + Dual/Multi audio.
  • Added a option If you DON'T WANT that your media file has a German audio track included.
  • Added a option If you PREFER that your media file has a German audio track included.

Requirements

@github-actions github-actions bot added Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section labels Apr 13, 2024
@TRaSH- TRaSH- requested a review from a team April 13, 2024 09:13
nuxencs
nuxencs previously approved these changes Apr 16, 2024
Copy link
Contributor

@nuxencs nuxencs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nuxencs
Copy link
Contributor

nuxencs commented Apr 16, 2024

probably a good idea to let @zakkarry proofread it 😄

Copy link
Contributor

@zakkarry zakkarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

docs/json/guide-only/language-german-and-original.json Outdated Show resolved Hide resolved
docs/Radarr/Tips/How-to-setup-language-custom-formats.md Outdated Show resolved Hide resolved
docs/Radarr/Tips/How-to-setup-language-custom-formats.md Outdated Show resolved Hide resolved
docs/Radarr/Tips/How-to-setup-language-custom-formats.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zakkarry zakkarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only had one suggestion for a block, didn't check anything besides grammar.

docs/Radarr/Tips/How-to-setup-language-custom-formats.md Outdated Show resolved Hide resolved
@TRaSH- TRaSH- requested a review from zakkarry May 9, 2024 06:38
zakkarry
zakkarry previously approved these changes May 9, 2024
@nuxencs nuxencs added the Do Not Merge Do Not Merge label May 9, 2024
@TRaSH- TRaSH- removed the Do Not Merge Do Not Merge label May 12, 2024
Copy link
Contributor

@nuxencs nuxencs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline for admonition per mkdocs documentation

@nuxencs nuxencs force-pushed the feat/guide-starr-language-tips-add-german-dual-and-multi branch from aecef99 to a8673d8 Compare May 12, 2024 18:27
@TRaSH- TRaSH- force-pushed the feat/guide-starr-language-tips-add-german-dual-and-multi branch from 4bfb39d to 41bf284 Compare May 15, 2024 18:21
@TRaSH- TRaSH- requested a review from nuxencs May 15, 2024 18:23
Copy link
Contributor

@nuxencs nuxencs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TRaSH- TRaSH- merged commit c58c9ea into master May 15, 2024
9 checks passed
@TRaSH- TRaSH- deleted the feat/guide-starr-language-tips-add-german-dual-and-multi branch May 15, 2024 18:28
Lokilicious pushed a commit to Lokilicious/Guides that referenced this pull request May 29, 2024
…des#1880)

* feat(guide): Starr language tips add German dual and multi

* fixed: url redirect failure

* Apply suggestions from code review

Co-authored-by: zakary <[email protected]>

* Update docs/Radarr/Tips/How-to-setup-language-custom-formats.md

Co-authored-by: zakary <[email protected]>

* Apply suggestions from code review

Co-authored-by: nuxen <[email protected]>

---------

Co-authored-by: zakary <[email protected]>
Co-authored-by: nuxen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants