Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter img src attribute #1167

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Filter img src attribute #1167

wants to merge 3 commits into from

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Jun 20, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Only allow external image urls with https:// in room description

@SamuelWei SamuelWei requested a review from Sabr1n4W June 20, 2024 16:46
Copy link

cypress bot commented Jun 20, 2024

Passing run #89 ↗︎

0 34 0 0 Flakiness 0

Details:

Filter img src attribute
Project: PILOS Commit: 9e27340602
Status: Passed Duration: 00:33 💡
Started: Jun 25, 2024 8:05 AM Ended: Jun 25, 2024 8:06 AM

Review all test suite changes for PR #1167 ↗︎

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (041438f) to head (9e27340).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1167   +/-   ##
==========================================
  Coverage      95.86%   95.86%           
  Complexity      1295     1295           
==========================================
  Files            198      198           
  Lines           4427     4427           
==========================================
  Hits            4244     4244           
  Misses           183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelWei
Copy link
Collaborator Author

Remove http from resources/js/components/TipTapImage.vue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant