Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress system tests #1166

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Jun 19, 2024

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Add some basic system tests to test the whole pipline: Docker Image -> Docker Compose -> Backend <- API -> Frontend

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (1c87660) to head (03167a5).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1166      +/-   ##
=============================================
- Coverage      95.86%   95.84%   -0.03%     
  Complexity      1295     1295              
=============================================
  Files            198      198              
  Lines           4427     4427              
=============================================
- Hits            4244     4243       -1     
- Misses           183      184       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jun 20, 2024

Passing run #85 ↗︎

0 46 0 0 Flakiness 0

Details:

Add cypress system tests
Project: PILOS Commit: 03167a556e
Status: Passed Duration: 02:48 💡
Started: Jun 21, 2024 3:00 PM Ended: Jun 21, 2024 3:03 PM

Review all test suite changes for PR #1166 ↗︎

@SamuelWei SamuelWei changed the title Add cypress integration tests Add cypress system tests Jun 20, 2024
@SamuelWei SamuelWei requested a review from Sabr1n4W June 20, 2024 11:10
Copy link
Contributor

@Sabr1n4W Sabr1n4W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly not reviewed yet but maybe add following changes:

  • Replace .should('contain', '...') with .should('have.text', '...'), .should('include.text', '...') or .should('include', '...') (last one mostly for checking url)
  • Add .should('be.visible') after cy.contains('...') when checking if a specific text is shown to make sure that it is really visible

Changes will most likely also be added for the frontend tests (#1150, 8dd2dfc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants