Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: able to run multiple pytest cases #547

Closed
wants to merge 2 commits into from
Closed

Conversation

wangyoucao577
Copy link
Collaborator

  • allow to run multiple test cases for python extensions
  • let users to customize the pytest args for more flexibility

@halajohn
Copy link
Member

This method can partially address the issue, but it will cause a memory leak. Although the leak occurs at the end of testing and is not particularly critical, a better solution is as follows. It has already been implemented in the main branch, and the basic principle remains the same.

https://github.com/TEN-framework/ten_framework/blob/main/packages/core_extensions/default_async_extension_python/tests/conftest.py

@halajohn halajohn closed this Jan 12, 2025
@wangyoucao577 wangyoucao577 deleted the bugfix/pytest branch January 12, 2025 12:25
@wangyoucao577
Copy link
Collaborator Author

OK. How about change python -s tests/ to pytest tests/ "$@" so that users can have more control of the pytest running.

@halajohn
Copy link
Member

No problem, I think it's great. I'll add this change to my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants