Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable dynamic loading in Python main app #502

Merged
merged 2 commits into from
Jan 3, 2025
Merged

feat: enable dynamic loading in Python main app #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd24be9
feat: enable dynamic loading in Python main app
sunxilin Jan 3, 2025
7108e31
Merge branch 'main' into 500-enable-the-mechanism-for-dynamically-loa…
halajohn Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions core/src/ten_runtime/binding/python/interface/ten/ten_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from libten_runtime_python import _Extension, _TenEnv
from .error import TenError
from .ten_env_attach_to_enum import _TenEnvAttachTo
from .cmd_result import CmdResult
from .cmd import Cmd
from .video_frame import VideoFrame
Expand Down Expand Up @@ -43,19 +42,6 @@ def _on_release(self) -> None:
self._release_handler()

def on_configure_done(self) -> None:
from .addon_manager import _AddonManager

if self._internal._attach_to == _TenEnvAttachTo.APP:
# Load all python addons when app on_configure_done.
_AddonManager.load_all_addons()

# In the current use of the TEN framework's Python environment,
# there is no need to pass any `register_ctx` object into the
# register handler of the Python addon. Therefore, for now, simply
# passing `None` is sufficient. If needed in the future, we can
# consider what information should be passed to the register
# handler of the Python addon.
_AddonManager.register_all_addons(None)
return self._internal.on_configure_done()

def on_init_done(self) -> None:
Expand Down
5 changes: 5 additions & 0 deletions core/src/ten_runtime/binding/python/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
"type": "system",
"name": "ten_runtime",
"version": "0.6.0"
},
{
"type": "addon_loader",
"name": "python_addon_loader",
"version": "0.6.0"
}
],
"package": {
Expand Down
5 changes: 0 additions & 5 deletions ...python/cpp_app_multi_process_python/cpp_app_multi_process_python_app_source/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@
"name": "default_extension_python",
"version": "0.6.0"
},
{
"type": "addon_loader",
"name": "python_addon_loader",
"version": "0.6.0"
},
{
"type": "extension",
"name": "simple_echo_cpp",
Expand Down
5 changes: 0 additions & 5 deletions tests/ten_runtime/integration/python/cpp_app_python/cpp_app_python_app_source/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@
"name": "default_extension_python",
"version": "0.6.0"
},
{
"type": "addon_loader",
"name": "python_addon_loader",
"version": "0.6.0"
},
{
"type": "extension",
"name": "simple_echo_cpp",
Expand Down
5 changes: 0 additions & 5 deletions ...tion/python/go_app_async_extension_python/go_app_async_extension_python_app/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@
"name": "default_extension_python",
"version": "0.6.0"
},
{
"type": "addon_loader",
"name": "python_addon_loader",
"version": "0.6.0"
},
{
"type": "extension",
"name": "simple_echo_cpp",
Expand Down
5 changes: 0 additions & 5 deletions tests/ten_runtime/integration/python/go_app_cythonize/go_app_cythonize_app/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@
"name": "default_extension_python",
"version": "0.6.0"
},
{
"type": "addon_loader",
"name": "python_addon_loader",
"version": "0.6.0"
},
{
"type": "extension",
"name": "simple_echo_cpp",
Expand Down
5 changes: 0 additions & 5 deletions ...ntegration/python/go_app_partially_cythonize/go_app_partially_cythonize_app/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@
"name": "default_extension_python",
"version": "0.6.0"
},
{
"type": "addon_loader",
"name": "python_addon_loader",
"version": "0.6.0"
},
{
"type": "extension",
"name": "simple_echo_cpp",
Expand Down
5 changes: 0 additions & 5 deletions tests/ten_runtime/integration/python/go_app_python/go_app_python_app/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@
"name": "default_extension_python",
"version": "0.6.0"
},
{
"type": "addon_loader",
"name": "python_addon_loader",
"version": "0.6.0"
},
{
"type": "extension",
"name": "simple_echo_cpp",
Expand Down
5 changes: 0 additions & 5 deletions .../ten_runtime/integration/python/unused_addon_python/unused_addon_python_app/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@
"name": "default_extension_python",
"version": "0.6.0"
},
{
"type": "addon_loader",
"name": "python_addon_loader",
"version": "0.6.0"
},
{
"type": "extension",
"name": "simple_echo_cpp",
Expand Down
Loading