fix complex merging of attrs, #687 #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odd2odds so that it does not "justcopy" attDef elements that are not defined in the source class. This is a bit complicated, see @joeytakeda’s explanation in #687 itself.
sydb
changed the title
|
Noting that @HelenaSabel , @sydb , and @ebeshero tested this with a few different ODD scenarios before agreeing to merge this as a much-needed bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify odd2odds so that it does not "justcopy" attDef elements that are not defined in the source class. This is a bit complicated, see our explanation in #687 itself.