Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README creation improvements ala TEI ticket 2070 #638

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

sydb
Copy link
Member

@sydb sydb commented Oct 23, 2023

Per TEI #2070 step 1:

  • Do not create links for <gi> or <name type="class"> if version number < 1.0
  • Presume class names are encoded with <name type="class"> (not <ident>)
  • Generate correct link for those (few) version numbers that are only major.minor, not major.minor.patch (by appending ".0")

WARNING
This PR cannot be considered in isolation, it must be combined with the corresponding PR in the TEI repo.

@sydb sydb added type: bug A bug report. target: build Concerning the build process, e.g. the Makefile or build.xml labels Oct 23, 2023
@sydb sydb added this to the Release 7.56.0 milestone Oct 23, 2023
@ebeshero ebeshero self-requested a review October 26, 2023 19:28
@ebeshero
Copy link
Member

I will look at this before the next release!

profiles/readme/html/to.xsl Outdated Show resolved Hide resolved
@ebeshero
Copy link
Member

Okay--it looks like we need to merge in the PR on the Guidelines repo first--to make the revised Readme XML files available for the revised processing here on Stylesheets. Is that the idea, @sydb ?

@sydb
Copy link
Member Author

sydb commented Oct 30, 2023

I have not thought about it. I do not think it matters which is first, at least not measured in minutes, beyond a possible temporary build failure. But they should both be merged the same day, or both should be rejected. It would probably be annoyingly problematic on release day if one had been merged and the other had not.

@sydb
Copy link
Member Author

sydb commented Nov 4, 2023

I merged the latest from Stylesheets dev branch into this branch (sydb_TEI_2070) and at the same time the latest from TEI dev branch into TEI sydb_2070. Both Test/ and Test2/ passed, and the Guidelines built without error or failure.

@raffazizzi raffazizzi merged commit 3a94a13 into dev Nov 9, 2023
4 checks passed
@raffazizzi raffazizzi added this to the Release 7.56.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: build Concerning the build process, e.g. the Makefile or build.xml type: bug A bug report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants