Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13054] Added an input searching bar above the dropdown list #13192

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Shibui-Li-1998
Copy link

Fixes #13054

Outline of Solution

1. Code Change Location:

The following files were updated to implement the feature:

2. Details of the Changes:

  • Added a text input field above the dropdown student list to facilitate search.
  • Implemented logic to allow users to search for students by entering substrings of their names.
  • Manually tested the new feature by inputting various substrings to ensure accurate search functionality.
  • Added new test cases to cover the updated functionality.

3. Demonstration:

Before:
Before

After:
After1
After2

Copy link

Hi @Shibui-Li-1998, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@Shibui-Li-1998
Copy link
Author

We have solved the issue #13054 by adding a new searching bar and the user can input any substrings there to search the recipient.

@Shibui-Li-1998 Shibui-Li-1998 marked this pull request as draft October 25, 2024 07:22
@Shibui-Li-1998 Shibui-Li-1998 changed the title Resolve issue #13054 [#13054] Added an input searching bar above the dropdown list Oct 26, 2024
@Shibui-Li-1998 Shibui-Li-1998 marked this pull request as ready for review October 26, 2024 05:15
@Shibui-Li-1998
Copy link
Author

Hi @Shibui-Li-1998, thank you for your interest in contributing to TEAMMATES! However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

We have modified the title. Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make substrings of the name in dropdown selections of recipient to be searchable
3 participants