Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting some enhancements #13121

Closed
wants to merge 1 commit into from

Conversation

TaylorPhelps
Copy link

Refactoring getProperty method: refactored the getProperty method to handle default values more efficiently and avoid redundant code.

Corrected initialization of static fields: ensured that the static fields in the Config class are initialized properly by reading values from the build.template.properties file.

Handled environment-specific properties: The Config class now handles properties differently based on whether the application is running in a development environment (dev.properties) or a production environment (build.properties).

Fixed logging: ensured that the application logs meaningful information during startup, such as the instance ID, zone rules version, and server startup messages. This helps in monitoring and debugging the application.

Copy link

Hi @TaylorPhelps, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@weiquu
Copy link
Contributor

weiquu commented Jun 10, 2024

Closing as not tagged to any issue. Do read through our contribution guidelines and follow the processes there.

@weiquu weiquu closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants