Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12664] Instructor's Student Records Page: Accessibility issue for comment buttons #13099

Conversation

steffibentley
Copy link

Fixes #12664

Outline of Solution

  1. Added aria-labels to the edit comment button and the delete comment button on the "Instructor's Student Records Page" to serve as more meaningful descriptions for a screen reader.
  2. I switched the placement of the discard and save buttons so that the screen reader goes to Discard and then Save.

Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @steffibentley, thanks for the PR. Our goal here is to have the screen reader read it in the correct order without changing the positions of the buttons

If you are still interested, you can give this a try, if not please close the PR so someone else can give it a try

@dishenggg dishenggg added the s.Ongoing The PR is being worked on by the author(s) label Jun 22, 2024
@weiquu
Copy link
Contributor

weiquu commented Jun 29, 2024

Closing due to inactivity

@weiquu weiquu closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor's Student Records Page: Accessibility issue for comment buttons
3 participants