Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate InstructorCourseStudentDetailsEditPageE2ETest #13069

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

weiquu
Copy link
Contributor

@weiquu weiquu commented Apr 20, 2024

Part of #12048

Had to re-run component-testing (ubuntu-latest) 2 additional times before it passed (GetStudentsActionIT was failing) - not sure why it's unstable. Other checks were running at the same time, but idk if that's causing the issue

@weiquu weiquu marked this pull request as ready for review April 20, 2024 14:29
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 70 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

Copy link
Contributor

@mingyuanc mingyuanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingyuanc mingyuanc added the s.FinalReview The PR is ready for final review label Jul 8, 2024
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domoberzin domoberzin merged commit 13a1891 into TEAMMATES:master Jul 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants