[#11878] Fix console errors (#13058)

TEAMMATES · Apr 19, 2024 · f8bae93 · f8bae93
1 parent 1027334
commit f8bae93
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 19 deletions.
diff --git a/...ponents/account-requests-table/__snapshots__/account-request-table.component.spec.ts.snap b/...ponents/account-requests-table/__snapshots__/account-request-table.component.spec.ts.snap
@@ -85,7 +85,6 @@ exports[`AccountRequestTableComponent should display account requests with no re
  >
  <div>
  <a
- href="javascript:;"
  id="edit-account-request-0"
  >
  <i
@@ -98,7 +97,6 @@ exports[`AccountRequestTableComponent should display account requests with no re
  placement="top"
  >
  <a
- href="javascript:;"
  id="delete-account-request-0"
  >
  <i
@@ -108,7 +106,6 @@ exports[`AccountRequestTableComponent should display account requests with no re
  </div>
  <div>
  <a
- href="javascript:;"
  id="view-account-request-0"
  >
  <i
@@ -190,7 +187,6 @@ exports[`AccountRequestTableComponent should display account requests with no re
  >
  <div>
  <a
- href="javascript:;"
  id="edit-account-request-1"
  >
  <i
@@ -203,7 +199,6 @@ exports[`AccountRequestTableComponent should display account requests with no re
  placement="top"
  >
  <a
- href="javascript:;"
  id="delete-account-request-1"
  >
  <i
@@ -213,7 +208,6 @@ exports[`AccountRequestTableComponent should display account requests with no re
  </div>
  <div>
  <a
- href="javascript:;"
  id="view-account-request-1"
  >
  <i
@@ -383,7 +377,6 @@ exports[`AccountRequestTableComponent should display account requests with reset
  >
  <div>
  <a
- href="javascript:;"
  id="edit-account-request-0"
  >
  <i
@@ -396,7 +389,6 @@ exports[`AccountRequestTableComponent should display account requests with reset
  placement="top"
  >
  <a
- href="javascript:;"
  id="delete-account-request-0"
  >
  <i
@@ -406,7 +398,6 @@ exports[`AccountRequestTableComponent should display account requests with reset
  </div>
  <div>
  <a
- href="javascript:;"
  id="view-account-request-0"
  >
  <i
@@ -507,7 +498,6 @@ exports[`AccountRequestTableComponent should display account requests with reset
  >
  <div>
  <a
- href="javascript:;"
  id="edit-account-request-1"
  >
  <i
@@ -520,7 +510,6 @@ exports[`AccountRequestTableComponent should display account requests with reset
  placement="top"
  >
  <a
- href="javascript:;"
  id="delete-account-request-1"
  >
  <i
@@ -530,7 +519,6 @@ exports[`AccountRequestTableComponent should display account requests with reset
  </div>
  <div>
  <a
- href="javascript:;"
  id="view-account-request-1"
  >
  <i
@@ -685,7 +673,6 @@ exports[`AccountRequestTableComponent should snap with an expanded account reque
  >
  <div>
  <a
- href="javascript:;"
  id="edit-account-request-0"
  >
  <i
@@ -698,7 +685,6 @@ exports[`AccountRequestTableComponent should snap with an expanded account reque
  placement="top"
  >
  <a
- href="javascript:;"
  id="delete-account-request-0"
  >
  <i
@@ -708,7 +694,6 @@ exports[`AccountRequestTableComponent should snap with an expanded account reque
  </div>
  <div>
  <a
- href="javascript:;"
  id="view-account-request-0"
  >
  <i

diff --git a/src/web/app/components/account-requests-table/account-request-table.component.html b/src/web/app/components/account-requests-table/account-request-table.component.html
@@ -52,17 +52,17 @@
  <td class="align-middle">
  <div class="d-flex flex-row align-items-center justify-content-center gap-2">
  <div>
- <a id="edit-account-request-{{i}}" href="javascript:;" (click)="$event.stopPropagation(); editAccountRequest(accountRequest);">
+ <a id="edit-account-request-{{i}}" (click)="$event.stopPropagation(); editAccountRequest(accountRequest);">
  <i class="fa-solid fa-pen"></i>
  </a>
  </div>
  <div class="ngb-tooltip-class" [ngbTooltip]="accountRequest.registeredAtText && 'Account requests of registered instructors cannot be deleted'" placement="top">
- <a id="delete-account-request-{{i}}" href="javascript:;" (click)="$event.stopPropagation(); deleteAccountRequest(accountRequest)">
+ <a id="delete-account-request-{{i}}" (click)="$event.stopPropagation(); deleteAccountRequest(accountRequest)">
  <i class="fa-solid fa-trash"></i>
  </a>
  </div>
  <div>
- <a id="view-account-request-{{i}}" href="javascript:;" (click)="$event.stopPropagation(); viewAccountRequest(accountRequest)">
+ <a id="view-account-request-{{i}}" (click)="$event.stopPropagation(); viewAccountRequest(accountRequest)">
  <i class="fa-solid fa-eye"></i>
  </a>
  </div>

diff --git a/src/web/app/components/account-requests-table/account-request-table.component.ts b/src/web/app/components/account-requests-table/account-request-table.component.ts
@@ -84,7 +84,7 @@ export class AccountRequestTableComponent {
  this.statusMessageService.showErrorToast(resp.error.message);
  },
  });
- });
+ }, () => {});
  }
 
  approveAccountRequest(accountRequest: AccountRequestTableRowModel): void {