chore: enable optional verification_method for DID Document
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re. https://www.w3.org/TR/did-core/#did-document-properties, the veriication_method property is not required. In fact, the TBD-hosted DID document used is tests does not include the Verification method. Make it optional, especially during (de-)serialization to ensure compatibility with the spec. Note: the web5-spec disagrees with the DID-core spec on this, it may be a legacy but it's possible the web5-spec should be updated as well to match did-core.
enmand
requested review from
KendallWeihe,
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
enmand
changed the title
verification_method is not required for DID Documentverification_method is not required for DID Document
enmand
changed the title
verification_method is not required for DID Documentverification_method for DID Document
|
Thanks for splitting this out @enmand 👍 This one may linger for a bit, while we work through a few higher priority items. And once we move forward with this, I want to consider implications such as the three I listed here. Also, take not of this comment -- specifically, for did:dht we should ensure that we are never in a situation where we make available a did:dht Document with an empty |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re. https://www.w3.org/TR/did-core/#did-document-properties, the veriication_method property is not required. In fact, the TBD-hosted DID document used is tests does not include the Verification method.
This PR makes it optional, especially during (de-)serialization to ensure compatibility with the spec.
Note: the web5-spec disagrees with the DID-core spec on this. See #231 for discussion and #190 (comment) for additional context.