Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up feedback widget #449

Merged
merged 27 commits into from May 18, 2023
Merged

Set up feedback widget #449

merged 27 commits into from May 18, 2023

Conversation

dayhaysoos
Copy link
Contributor

Creating this PR to get feedback early. This is currently how the feedback widget looks below:

Screenshot 2023-05-08 at 4 21 24 PM

Note

It's missing the "Edit This Page" links because it's been a bit harder getting those URLs than I expected. For the sake of moving forward I'd love to get this widget merged ASAP and make a new ticket for solving that editUrl issue.

Would like feedback from @EbonyLouis @bobbilee19 @kirahsapong

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for tbd-website-developer ready!

Name Link
🔨 Latest commit a07ff70
🔍 Latest deploy log https://app.netlify.com/sites/tbd-website-developer/deploys/64655710d98eb900086bc0ce
😎 Deploy Preview https://deploy-preview-449--tbd-website-developer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ALRubinger
Copy link
Contributor

@dayhaysoos Thanks!

Can we have it float in a minimized mode so it's always visible in the bottom right, rather than pinned to the bottom of the page. And on expand, shows as you have it here?

@dayhaysoos
Copy link
Contributor Author

@ALRubinger I'm not sure if that makes for the best docs experience. Normally, those types of pop ups are designed for marketing or sales engagements and I personally feel like I'd be annoyed by seeing something like that floating on the page.

I don't think I've ever seen Docs do something like that either, normally feedback options or surveys are at the bottom.

I also think we should get @EbonyLouis opinion on this because she was expecting something at the bottom:

#442 (comment)

@EbonyLouis
Copy link
Contributor

Yea I do think it looks odd, can we see how it would look with a line to break up the section? I also agree those type of pop ups annoy me, i always try and exit them out as fast as possible. So I would like for us to not do that, I like it at the bottom of the page it just looks odd

@EbonyLouis
Copy link
Contributor

@dayhaysoos we might just need kirah to make it pretty, maybe we just need to add color like the boxes on the docs home page? like you said play around and send screenshots

@ALRubinger
Copy link
Contributor

@ALRubinger I'm not sure if that makes for the best docs experience. Normally, those types of pop ups are designed for marketing or sales engagements and I personally feel like I'd be annoyed by seeing something like that floating on the page.

I agree!

EbonyLouis
EbonyLouis previously approved these changes May 11, 2023
@EbonyLouis EbonyLouis dismissed their stale review May 11, 2023 19:07

want to take another look at the font sizing

@EbonyLouis EbonyLouis self-requested a review May 11, 2023 19:07
@EbonyLouis
Copy link
Contributor

EbonyLouis commented May 11, 2023

@dayhaysoos just looked at the preview its way too big, feels like we're yelling at them lol

@ALRubinger
Copy link
Contributor

Starting to come together!

Margin looks like it extends past the margin on pieces above it?

image

@EbonyLouis
Copy link
Contributor

EbonyLouis commented May 12, 2023

Contributor page hackmd for review: https://hackmd.io/_J1S7dG1SeC3kAa-drm4jQ?both

also somehow the title sizes got messed up so "good first issue", "new first issue", etc sizing is off.

@ALRubinger
Copy link
Contributor

Will need to rebase atop phase-4 to see the true latest and prepare for clean merge

@ALRubinger ALRubinger self-requested a review May 16, 2023 17:09
adding events section
@EbonyLouis EbonyLouis removed the request for review from kirahsapong May 16, 2023 17:46
@EbonyLouis EbonyLouis marked this pull request as ready for review May 16, 2023 17:47
Copy link
Contributor

@ALRubinger ALRubinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New Code of Conduct link is /open-source/code-of-conduct, pending this PR; please update link in opening paragraph so they go into phase-4 together?
  • Second paragraph: "contributing.md" > CONTRIBUTING.md, both uppercase and stylized as monospace.
  • Proposed copy for "Propose a new Project": "We believe in community-driven innovation. If you have an idea for a project that helps Web5, tbDEX, or the TBD open source ecosystem, we'd love to talk with you about our Incubation Program"
  • Under "New Open Issues", recommend striking the sentence "We currently have 51 repositories.". We'll never be able to keep that number up to date ;) And a lot of those projects may be archival.

EbonyLouis and others added 6 commits May 16, 2023 17:39
-changed contributing.md to caps
-updated 'propose new project' paragraph 
-scrapped last line in 'good first issue'
@dayhaysoos
Copy link
Contributor Author

I'm pretty sure this is good to go! We can open up new issues for improvements moving forward

@dayhaysoos dayhaysoos merged commit 507ec11 into phase-4 May 18, 2023
5 checks passed
@dayhaysoos dayhaysoos deleted the issue-448/create-feedback-widget branch May 18, 2023 11:32
ALRubinger pushed a commit that referenced this pull request May 18, 2023
* Set up feedback widget

* added expandability

* Removed need for expand animation

* remove unneeded code

* add community page with feedback widget

* update feedback widget with content and some styling changes

* Set up feedback widget

* added expandability

* Removed need for expand animation

* remove unneeded code

* add community page with feedback widget

* update feedback widget with content and some styling changes

* Update URLs for phase-4

* update copy

* fix link

* Update contributing.mdx

adding events section

* Update contributing.mdx

-changed contributing.md to caps
-updated 'propose new project' paragraph 
-scrapped last line in 'good first issue'

* test

* Update contributing.mdx

* Update contributing.mdx

* updated with fixed height

---------

Co-authored-by: Ebony Louis <[email protected]>
ALRubinger added a commit that referenced this pull request May 18, 2023
ALRubinger added a commit that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants