-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devel taf #2
base: devel-taf
Are you sure you want to change the base?
Devel taf #2
Conversation
Hi @vini2001 and @lawrenceCA. Thanks for the PR, I'm going to check the commits. Sorry I took some days out of code, so until today I saw the PR. Greetings! |
The Idea for this package is make a TAF-Verificator command line application, but an API package too to use in Dart projects. And as you can see, there is the same project in Python language. And I hope to create the same in TypeScript and Go. Your help is always welcoming 👍🏼 |
I have finished to review the commits. Sadly I can't accept your Pull Request, and it is for several reasons. I see one change in the VALID regex of the TAF, the As a recomendation, first open an issue with a specific change to make. Next, do your changes in a few commits, say about 3 commits, no more and send your Pull Request. I apologize too, because I have not added a CONTRIBUTE.md file where I put the rules of how to contribute to the project. I will be doing that in the next few days. One more time, thanks for your PR, your help will be welcoming always. I hope not to discourage you to continue contributing. |
Hi @diego-garro . However, I suggest you take a look at my fork for your following work as it will save you some time :) Hope this helps, we'll continue to maintain our fork as we spot issues. |
Excellent @vini2001, some features and fixes are very helpful. Greetings. |
Set of changes to complete the TAF parser
(small bits may still be missing, but a lot of edge cases were handled)