Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(card): linked images #419

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 31, 2024

Overview

Allow linking an image in a card (without breaking layout).

Related

Changes

  • added selectors :--c-card__image, :--c-card__image-link
  • added demo of linked images in cards
  • added mixin block-link(-…)

Testing

  1. Visit this content in the demo:
  2. Test the images:
    • hover (mouse over)
    • active (click)

UI

light.mov
dark.mov

@github-actions github-actions bot added the enhancement Improvements or additions to existing features label Oct 31, 2024
@wesleyboar wesleyboar added minor A feature in backward-compatible manner enhancement Improvements or additions to existing features and removed enhancement Improvements or additions to existing features labels Oct 31, 2024
@wesleyboar wesleyboar marked this pull request as ready for review October 31, 2024 23:29
@wesleyboar wesleyboar merged commit 03047f8 into main Oct 31, 2024
@wesleyboar wesleyboar deleted the enhance/gh-411-image-as-link-in-card branch October 31, 2024 23:30
@wesleyboar
Copy link
Member Author

fixes #411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or additions to existing features minor A feature in backward-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant