Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tup-639 move c-button font-weight bold to cms #253

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 2, 2023

Overview

The .c-button font weight should be bold only on CMS.

And remove font-weight: var(--medium) because it is always overwritten.

Related

Changes

  • removed font-weight medium of c-button not as a link
  • removed font-weight bold of a c-button in a c-card

Testing

  1. Test this change on https://www.tacc.utexas.edu/education/k-12-students/high-school-camps/gencyber/#application.
    See https://github.com/wesleyboar/tup-ui-migration-to-core.
  2. Verify "APPLICATION CLOSED" button is bold.
  3. Verify "APPLICATION CLOSED" button has no instances of font-weight: var(--medium).

UI

c-button c-card
core-styles c-button core-styles c-card

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Nov 2, 2023
@wesleyboar wesleyboar added the patch A backward-compatible fix label Nov 2, 2023
@wesleyboar wesleyboar changed the title fix: tup-617 c-button font-weight should be bold fix: tup-617 move c-button font-weight bold to cms Nov 2, 2023
@wesleyboar wesleyboar marked this pull request as ready for review November 2, 2023 21:44
@wesleyboar wesleyboar changed the title fix: tup-617 move c-button font-weight bold to cms fix: tup-639 move c-button font-weight bold to cms Nov 2, 2023
Copy link
Collaborator

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

• Tested on Core-CMS and TUP-UI, no side effects
• Looks like a simple change, migrated from tup-ui -> core-styles (then deleted) -> to core-cms

@wesleyboar wesleyboar merged commit 915c0ef into main Nov 3, 2023
@wesleyboar wesleyboar deleted the fix/tup-617-c-button-font-weight branch November 3, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants