Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During export, check for identifier collisions in output #73

Open
amykyta3 opened this issue Nov 7, 2023 · 0 comments
Open

During export, check for identifier collisions in output #73

amykyta3 opened this issue Nov 7, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@amykyta3
Copy link
Member

amykyta3 commented Nov 7, 2023

See example in SystemRDL/systemrdl-compiler#193

Current implementation will silently emit colliding output, or even reuse an incorrect typedef.
Monitor for this and emit an error if it occurs.

Ideas for fix:

  • Temporarily generate prefixes using non-underscore characters that are impossible to specify in RDL source.
  • Use the above prefix as the source of truth to uniquely identify a type name
  • Replace special delimiter chars with underscores and check if it collides with an existing scope prefix elsewhere.
@amykyta3 amykyta3 added the feature request New feature or request label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Development

No branches or pull requests

1 participant