Skip to content

Commit

Permalink
Human 1.10
Browse files Browse the repository at this point in the history
  • Loading branch information
haowang-bioinfo committed Sep 14, 2021
2 parents 8580072 + 339ff64 commit 5b85413
Show file tree
Hide file tree
Showing 12 changed files with 420 additions and 192 deletions.
261 changes: 261 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,261 @@
{
"files": [
"README.md"
],
"imageSize": 80,
"contributorsPerLine": 8,
"contributorsSortAlphabetically": true,
"badgeTemplate": "[![All Contributors](https://img.shields.io/badge/all_contributors-<%= contributors.length %>-success.svg)](#contributors)",
"skipCi": "true",
"contributors": [
{
"login": "JonathanRob",
"name": "Jonathan Robinson",
"avatar_url": "https://avatars.githubusercontent.com/u/22366558?v=4",
"profile": "https://jonathanrob.github.io",
"contributions": [
"bug",
"code",
"data",
"doc",
"ideas",
"infra",
"platform",
"projectManagement",
"question",
"research",
"review",
"tutorial",
"talk"
]
},
{
"login": "Hao-Chalmers",
"name": "Hao Wang",
"avatar_url": "https://avatars.githubusercontent.com/u/21077367?v=4",
"profile": "https://orcid.org/0000-0001-7475-0136",
"contributions": [
"bug",
"code",
"data",
"doc",
"ideas",
"infra",
"platform",
"projectManagement",
"question",
"research",
"review",
"test",
"talk"
]
},
{
"login": "mihai-sysbio",
"name": "Mihail Anton",
"avatar_url": "https://avatars.githubusercontent.com/u/23480589?v=4",
"profile": "https://orcid.org/0000-0002-7753-9042",
"contributions": [
"bug",
"code",
"ideas",
"infra",
"review",
"test",
"talk"
]
},
{
"login": "pecholleyc",
"name": "Pierre-Etienne Cholley",
"avatar_url": "https://avatars.githubusercontent.com/u/26245751?v=4",
"profile": "",
"contributions": [
"bug",
"code",
"content",
"review"
]
},
{
"login": "pinarkocabas",
"name": "Pınar Kocabaş",
"avatar_url": "https://avatars.githubusercontent.com/u/32029599?v=4",
"profile": "",
"contributions": [
"bug"
]
},
{
"login": "PkiwiBird",
"name": "PkiwiBird",
"avatar_url": "https://avatars.githubusercontent.com/u/8766764?v=4",
"profile": "",
"contributions": [
"bug"
]
},
{
"login": "jorgemlferreira",
"name": "Jorge Ferreira",
"avatar_url": "https://avatars.githubusercontent.com/u/10344158?v=4",
"profile": "",
"contributions": [
"bug"
]
},
{
"login": "pecholley",
"name": "Pierre-Etienne Cholley",
"avatar_url": "https://avatars.githubusercontent.com/u/2399043?v=4",
"profile": "",
"contributions": [
"bug"
]
},
{
"login": "pranasag",
"name": "Pranas Grigaitis",
"avatar_url": "https://avatars.githubusercontent.com/u/38076281?v=4",
"profile": "",
"contributions": [
"bug",
"content",
"code"
]
},
{
"login": "avlant",
"name": "Avlant",
"avatar_url": "https://avatars.githubusercontent.com/u/5329888?v=4",
"profile": "https://github.com/avlant",
"contributions": [
"bug",
"content"
]
},
{
"login": "edkerk",
"name": "Eduard Kerkhoven",
"avatar_url": "https://avatars.githubusercontent.com/u/7326655?v=4",
"profile": "https://github.com/edkerk",
"contributions": [
"question"
]
},
{
"login": "simas232",
"name": "Simonas Marcišauskas",
"avatar_url": "https://avatars.githubusercontent.com/u/11994076?v=4",
"profile": "https://github.com/simas232",
"contributions": [
"question"
]
},
{
"login": "XuhangLi",
"name": "Xuhang Li",
"avatar_url": "https://avatars.githubusercontent.com/u/41695293?v=4",
"profile": "https://github.com/XuhangLi",
"contributions": [
"bug"
]
},
{
"login": "TunahanCakir",
"name": "TunahanCakir",
"avatar_url": "https://avatars.githubusercontent.com/u/71440332?v=4",
"profile": "https://github.com/TunahanCakir",
"contributions": [
"bug"
]
},
{
"login": "BenjaSanchez",
"name": "Benjamín Sánchez",
"avatar_url": "https://avatars.githubusercontent.com/u/9384349?v=4",
"profile": "https://github.com/BenjaSanchez",
"contributions": [
"question"
]
},
{
"login": "cherkaos",
"name": "Sarah Cherkaoui",
"avatar_url": "https://avatars.githubusercontent.com/u/4625396?v=4",
"profile": "https://github.com/cherkaos",
"contributions": [
"bug",
"content",
"code"
]
},
{
"login": "smoretti",
"name": "smoretti",
"avatar_url": "https://avatars.githubusercontent.com/u/3072880?v=4",
"profile": "https://orcid.org/0000-0003-3947-488X",
"contributions": [
"bug"
]
},
{
"login": "mpagni12",
"name": "Marco Pagni",
"avatar_url": "https://avatars.githubusercontent.com/u/45748199?v=4",
"profile": "https://github.com/mpagni12",
"contributions": [
"bug"
]
},
{
"login": "ANiknejad",
"name": "Anne Niknejad",
"avatar_url": "https://avatars.githubusercontent.com/u/2682520?v=4",
"profile": "https://github.com/ANiknejad",
"contributions": [
"bug",
"content"
]
},
{
"login": "CadavidJoseL",
"name": "Jose L. Cadavid",
"avatar_url": "https://avatars.githubusercontent.com/u/62765618?v=4",
"profile": "https://github.com/CadavidJoseL",
"contributions": [
"bug"
]
},
{
"login": "johan-gson",
"name": "johan-gson",
"avatar_url": "https://avatars.githubusercontent.com/u/32481323?v=4",
"profile": "https://github.com/johan-gson",
"contributions": [
"bug",
"content"
]
},
{
"login": "dweindl",
"name": "Daniel Weindl",
"avatar_url": "https://avatars.githubusercontent.com/u/18048784?v=4",
"profile": "https://github.com/dweindl",
"contributions": [
"bug"
]
},
{
"login": "Rasools",
"name": "Rasool Saghaleyni",
"avatar_url": "https://avatars.githubusercontent.com/u/22166601?v=4",
"profile": "https://github.com/Rasools",
"contributions": [
"ideas"
]
}
],
"repoType": "github",
"commitConvention": "none"
}
61 changes: 17 additions & 44 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
## Contributor guidelines
## Contributing guidelines

Contributions to Human-GEM are very welcome and greatly appreciated! Credit will always be given to anyone who contribute.
Contributions to **Human-GEM** are very welcome and greatly appreciated! Credit is given to everyone who contributes. This is done by either manually modifying the `.all-contributorsrc` or automatically with the `all-contributors` bot, and updating the `Contributors` sections of the `README` accordingly.

You can contribute in 2 main ways: by creating issues, and by sending pull requests (PRs) with additions, deletions, corrections, etc. to the model. Please follow the following guidelines:
You can contribute in **2** major ways: by creating issues, and by sending pull requests (PRs) with additions, deletions, corrections, etc. to the `yml` model and/or `tsv` annotation files. Please follow the following guidelines:

### Reporting issues in the model
### Reporting issues

Report an issue at https://github.com/SysBioChalmers/Human-GEM/issues if you note any of the following:
Report an issue at [here](https://github.com/SysBioChalmers/Human-GEM/issues), if you notice any of the following:

* Incorrect annotation for any model component.
* Incorrect annotation for any model components.
* Missing feature or field you would like the model to have.
* Bug/weird simulation results.
* Lacking documentation.
Expand All @@ -18,63 +18,35 @@ If you are unsure about the issue, consider asking first in our [Gitter chat roo

When creating the issue, please make sure:

* You checked that a similar issue does not exist already
* You tested your code (if any) with all requirements for running the model.
* You did your analysis in the `main` branch of the repository.
* You provide any necessary files/links needed for understanding the issue.
* You checked that a similar issue does not exist already

Feel free to also comment on any of the [open issues](https://github.com/SysBioChalmers/Human-GEM/issues).


### Contributing to the model
### Contributing to the model/annotation

If you want to contribute to the model with some additions or improvements, please consider starting by raising an issue and assign it to yourself to describe what you want to achieve. This way, we reduce the risk of duplicated efforts and you may also get suggestions on how to best proceed, e.g. there may be half-finished work in some branch that you could start with. Also, feel free to browse our [open issues](https://github.com/SysBioChalmers/Human-GEM/issues) and our [ongoing projects](https://github.com/SysBioChalmers/Human-GEM/projects): Anything tagged with "help wanted" is open to whoever wants to implement it.
If you want to contribute to the model with some additions or improvements, please always start by raising an issue for asking/describing what you want to achieve. This way, we reduce the risk of duplicated efforts and you may also get suggestions on how to best proceed, e.g. there may be half-finished work in some branch that you could work with. Also, feel free to browse our [open issues](https://github.com/SysBioChalmers/Human-GEM/issues) and our [ongoing projects](https://github.com/SysBioChalmers/Human-GEM/projects): Anything tagged with "help wanted" is open to whoever wants to implement it.

Here's how to set up Human-GEM for local development to contribute smaller features or changes that you can implement yourself:

1. Make sure that you have all [requirements](https://github.com/SysBioChalmers/Human-GEM#required-software) for contributing to Human-GEM. Note that COBRA and RAVEN should be cloned to your computer and not just downloaded.
Here's how to set up Human-GEM to contribute small features or changes. This should work for most curation work.

2. Fork the Human-GEM repository on GitHub (go to https://github.com/SysBioChalmers/Human-GEM & click on the upper right corner).
1. Fork the [Human-GEM](https://github.com/SysBioChalmers/Human-GEM) repository to your local, by clicking on the upper right corner. Then, switch to the `develop` branch before starting to work in the forked repository.

3. Clone your fork locally:
```
git clone https://github.com/<your Github name>/Human-GEM.git
```

4. Check out the branch that you want to contribute to. Most likely that will be `devel`:
```
git checkout devel
```

5. Create a branch for local development based on the previously checked out branch ([see below](#branching-model) for details on the branching model and how to name your branch):
```
git checkout -b name-of-your-branch
```

6. Now you can make your changes locally!
* If your changes are minor (e.g. a single chemical formula you wish to correct), you can do it directly from the command line.
* If your changes are not so small and require several steps, create a script that loads the model, reads data (if applicable), changes the model accordingly, and saves the model back.
* Each script should start with a commented section describing the script, explaining the parameters, and indicating your name and the date it was written. Existing functions can clarify what style should be used.
* Store scripts in the appropriate folder in `/code` and data (as `.tsv` files) in the appropriate folder in `/data`. If you think no folder is adequate for your script/data, feel free to create your own folder. Note that binary data such as `.mat` structures or `.xls` tables cannot be stored in the repo (as they cannot be version-controlled, and they increment too much the size of the repo).
* When you are done making changes, review locally your changes with `git diff` or any git client, to make sure you are modifying the model as you intended.
2. Modify model file `Human-GEM.yml` and/or annotation files `reactions.tsv`, `metabolites.tsv`, and `genes.tsv`, and commit changes as suggested below in "Semantic commits".

7. Commit your changes and push your branch to GitHub.
```
git add .
git commit -m "Title of your commit"
git push origin name-of-your-branch
```
[See below](#semantic-commits) for recommendations on how to name your commits. In case of larger updates, you can of course make several commits on a single contribution. However, if you need to make many commits, consider if your contribution could be instead split into separate branches (making it easier for reviewing later).
3. Submit a pull request from the `develop` branch of the forked repository to the `develop` branch of the original `SysBioChalmers/Human-GEM` repository. We recommend ticking the box "Allow edits from maintainers" if you wish for us to be able to contribute directly to your branch (speeding-up the reviewing process).

8. Submit a pull request through the GitHub website (https://help.github.com/articles/creating-a-pull-request-from-a-fork/) to the `devel` branch of the original SysBioChalmers repo (not to your fork). We recommend ticking the box "Allow edits from maintainers" if you wish for us to be able to contribute directly to your branch (speeding-up the reviewing process).

Finally, and for larger features that you want to work on collaboratively, you may consider to first request to join our development team to get write access to the repository so that you can create a branch directly in the main repository (or simply ask the administrator to create a branch for you). Once you have a new branch, you can push your changes directly to the main repository and when finished, submit a pull request from that branch to `devel`. [See below](#development-team-guidelines) for more details.
Finally, and for larger features that you want to work on collaboratively, you may consider to first request to join our development team to get write access to the repository so that you can create a branch directly in the main repository (or simply ask the administrator to create a branch for you). Once you have a new branch, you can push your changes directly to the main repository and when finished, submit a pull request from that branch to `develop`. [See below](#development-team-guidelines) for more details.

Thank you very much for contributing to Human-GEM!

#### Branching model

* `devel`: Is the branch to which all pull requests should be made.
* `develop`: Is the branch to which all pull requests should be made.

* `main`: Is only modified by the administrator and is the branch with the tested & reviewed model that is released or ready for the next release.

Expand Down Expand Up @@ -110,4 +82,5 @@ More examples [here](https://github.com/SysBioChalmers/Human-GEM/commits/main).

## Acknowledgments

These contribution guidelines were adapted from the guidelines of [SysBioChalmers/yeast-GEM](https://github.com/SysBioChalmers/yeast-GEM/blob/main/.github/CONTRIBUTING.md).
These contribution guidelines were adapted from the guidelines of [yeast-GEM](https://github.com/SysBioChalmers/yeast-GEM/blob/main/.github/CONTRIBUTING.md).

6 changes: 1 addition & 5 deletions .github/workflows/yaml-conversion.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: Test YAML conversion

on:
push:
branches: [ develop ]
pull_request:
branches: [ main, develop ]
on: [push, pull_request]

jobs:
yaml-conversion:
Expand Down
Loading

0 comments on commit 5b85413

Please sign in to comment.