Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation controller interactive pop gesture not working #389

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Navigation controller interactive pop gesture not working #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Source/SwipeController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,15 @@ extension SwipeController: UIGestureRecognizerDelegate {

return true
}

func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRequireFailureOf otherGestureRecognizer: UIGestureRecognizer) -> Bool {
if let topmost = UIApplication.topmostViewController() as? UINavigationController {
if gestureRecognizer == self.panGestureRecognizer && otherGestureRecognizer == topmost.interactivePopGestureRecognizer {
return true
}
}
return false
}
}

extension SwipeController: SwipeActionsViewDelegate {
Expand Down
14 changes: 14 additions & 0 deletions Source/UIApplication+Ext.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
//
// UIApplication+Ext.swift
// SwipeCellKit
//
// Created by Văn Tiến Tú on 4/19/20.
//

import UIKit

extension UIApplication {
static func topmostViewController() -> UIViewController? {
return UIApplication.shared.keyWindow?.rootViewController
}
}
4 changes: 4 additions & 0 deletions SwipeCellKit.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
B93ECA951EDEE8A700AE05AD /* SwipeCollectionViewCellDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = B93ECA941EDEE8A700AE05AD /* SwipeCollectionViewCellDelegate.swift */; };
B93ECA991EDEE93D00AE05AD /* SwipeAccessibilityCustomAction.swift in Sources */ = {isa = PBXBuildFile; fileRef = B93ECA981EDEE93D00AE05AD /* SwipeAccessibilityCustomAction.swift */; };
B93ECA9B1EDEEABA00AE05AD /* SwipeOptions.swift in Sources */ = {isa = PBXBuildFile; fileRef = B93ECA9A1EDEEABA00AE05AD /* SwipeOptions.swift */; };
EF934E6C244C669F0060A446 /* UIApplication+Ext.swift in Sources */ = {isa = PBXBuildFile; fileRef = EF934E6B244C669F0060A446 /* UIApplication+Ext.swift */; };
/* End PBXBuildFile section */

/* Begin PBXFileReference section */
Expand Down Expand Up @@ -58,6 +59,7 @@
B93ECA941EDEE8A700AE05AD /* SwipeCollectionViewCellDelegate.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SwipeCollectionViewCellDelegate.swift; sourceTree = "<group>"; };
B93ECA981EDEE93D00AE05AD /* SwipeAccessibilityCustomAction.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SwipeAccessibilityCustomAction.swift; sourceTree = "<group>"; };
B93ECA9A1EDEEABA00AE05AD /* SwipeOptions.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SwipeOptions.swift; sourceTree = "<group>"; };
EF934E6B244C669F0060A446 /* UIApplication+Ext.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIApplication+Ext.swift"; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -112,6 +114,7 @@
3FD016DE1E6D778700B54FFC /* SwipeExpanding.swift */,
3F19AD031E8D711C006B4B3A /* SwipeFeedback.swift */,
3F234AD51E44A94F00E22A38 /* Extensions.swift */,
EF934E6B244C669F0060A446 /* UIApplication+Ext.swift */,
3F234AD01E44A8F200E22A38 /* Supporting Files */,
);
path = Source;
Expand Down Expand Up @@ -206,6 +209,7 @@
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
EF934E6C244C669F0060A446 /* UIApplication+Ext.swift in Sources */,
3F234AD81E44A94F00E22A38 /* SwipeActionsView.swift in Sources */,
3F234AD71E44A94F00E22A38 /* SwipeAction.swift in Sources */,
3F3ED7101E486993009DD5D8 /* SwipeActionButton.swift in Sources */,
Expand Down