Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only detecting swipe to directions with items #378

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Only detecting swipe to directions with items #378

wants to merge 1 commit into from

Conversation

igorkulman
Copy link

Fixes #358

@peterkovacs
Copy link

I've solved this more generally in #381 as well.

@igorkulman
Copy link
Author

I've solved this more generally in #381 as well.

I would call it a different approach not a more general way. If I get it right you are letting the consumer decide if the menu should be shown vs my not trying to show it when there is nothing to show.

@peterkovacs
Copy link

I've solved this more generally in #381 as well.

I would call it a different approach not a more general way. If I get it right you are letting the consumer decide if the menu should be shown vs my not trying to show it when there is nothing to show.

Exactly. I would think it'd be nice to combine your canSwipe{Left,Right} into the default delegate implementation.

@overcyn
Copy link

overcyn commented May 30, 2020

Thanks @igorkulman this fixed the issue for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict with side menu
3 participants