Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #98

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Minor improvements #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eac25ef
Update playerStateSubject in JavaScript .onStateChange event
acosmicflamingo May 19, 2024
9592d52
Mark YouTubePlayer views and models with @MainActor
acosmicflamingo Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/HostingView/YouTubePlayerHostingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public class YouTubePlayerHostingBaseView: UIView {}
// MARK: - YouTubePlayerHostingView

/// The YouTubePlayer HostingView
@MainActor
public final class YouTubePlayerHostingView: YouTubePlayerHostingBaseView {

// MARK: Properties
Expand Down Expand Up @@ -62,7 +63,9 @@ public final class YouTubePlayerHostingView: YouTubePlayerHostingBaseView {

/// Deinit
deinit {
self.player.pause()
MainActor.assumeIsolated {
self.player.pause()
}
}

}
5 changes: 4 additions & 1 deletion Sources/ViewController/YouTubePlayerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public class YouTubePlayerBaseViewController: UIViewController {}
// MARK: - YouTubePlayerViewController

/// The YouTubePlayer ViewController
@MainActor
public final class YouTubePlayerViewController: YouTubePlayerBaseViewController {

// MARK: Properties
Expand Down Expand Up @@ -61,7 +62,9 @@ public final class YouTubePlayerViewController: YouTubePlayerBaseViewController

/// Deinit
deinit {
self.player.pause()
MainActor.assumeIsolated {
self.player.pause()
}
}

// MARK: View-Lifecycle
Expand Down
1 change: 1 addition & 0 deletions Sources/WebView/YouTubePlayerWebView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import WebKit
// MARK: - YouTubePlayerWebView

/// The YouTubePlayer WebView
@MainActor
final class YouTubePlayerWebView: WKWebView {

// MARK: Properties
Expand Down
3 changes: 3 additions & 0 deletions Sources/YouTubePlayer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import Foundation
// MARK: - YouTubePlayer

/// A YouTubePlayer
@MainActor
public final class YouTubePlayer: ObservableObject {

// MARK: Properties
Expand Down Expand Up @@ -239,6 +240,8 @@ private extension YouTubePlayer {
// Otherwise return out of function
return
}
// Send PlayerState
self.playerStateSubject.send(.ready)
// Send PlaybackState
self.playbackStateSubject.send(playbackState)
case .onPlaybackQualityChange:
Expand Down
Loading