fix based on #4 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvanBoxel
requested changes
Apr 8, 2022
src/index.tsx
Outdated
| @@ -16,7 +16,7 @@ export interface Props { | |||
|
|
|||
| const VisibilitySensor: React.FC<Props> = (props) => { | |||
| const myView: any = useRef(null); | |||
| const [lastValue, setLastValue] = useState<boolean>(false); | |||
| const [lastValue, setLastValue] = useState<boolean>(null); | |||
There was a problem hiding this comment.
👋🏽 Argument of type 'null' is not assignable to parameter of type 'boolean'. Why can't we stick with false?
There was a problem hiding this comment.
just following from this #4 (comment)
SvanBoxel
reviewed
Apr 13, 2022
| @@ -16,7 +16,7 @@ export interface Props { | |||
|
|
|||
| const VisibilitySensor: React.FC<Props> = (props) => { | |||
| const myView: any = useRef(null); | |||
| const [lastValue, setLastValue] = useState<boolean>(false); | |||
| const [lastValue, setLastValue] = useState<boolean | null>(null); | |||
There was a problem hiding this comment.
Sorry, me again with some feedback. I'm trying to understand why we go for a double type declaration here. What's the scenario where setting this to false (instead of null), and removing line 29, that it would still show undesired behavior?
Happy to merge this PR, just trying to wrap my head around why this would work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.