feat: implement reduced size estimation #13
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
reviewed
Aug 26, 2023
| @@ -425,9 +461,29 @@ const manualPackagesList = /** @type {const} */ ([ | |||
| } | |||
| }; | |||
|
|
|||
| const fetchOriginPackageSize = async (packageName) => { | |||
| const packageJson = await makeRequest('https://packagephobia.com/api.json', { | |||
There was a problem hiding this comment.
Is it possible to use registry.npmjs.org instead? registry.npmjs.org is way more reliable.
E.g. You can get unpackedSize and fileCount from https://registry.npmjs.org/nolyfill/latest.
There was a problem hiding this comment.
It's possible but only if the dependency tree is evaluated correctly. The tree of yarn is incorrect currently, however.
Check the discussions in the tg group for details.
|
Question. Why is caching necessary? ( Or where do we want to cache them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs: