Skip to content

Commit

Permalink
Whitelist Crashlytics Domains
Browse files Browse the repository at this point in the history
  • Loading branch information
SukkaW committed Oct 6, 2024
1 parent d3609df commit 0ca236d
Show file tree
Hide file tree
Showing 3 changed files with 66 additions and 28 deletions.
4 changes: 4 additions & 0 deletions Build/build-cdn-download-conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { appendArrayInPlace } from './lib/append-array-in-place';
import { SOURCE_DIR } from './constants/dir';
import { processLine } from './lib/process-line';
import { DomainsetOutput } from './lib/create-file';
import { CRASHLYTICS_WHITELIST } from './constants/reject-data-source';

const getS3OSSDomainsPromise = (async (): Promise<string[]> => {
const trie = createTrie((await getPublicSuffixListTextPromise()).reduce<string[]>(
Expand Down Expand Up @@ -70,6 +71,9 @@ export const buildCdnDownloadConf = task(require.main === module, __filename)(as
appendArrayInPlace(downloadDomainSet, S3OSSDomains.map(domain => `.${domain}`));
appendArrayInPlace(downloadDomainSet, steamDomainSet);

// we have whitelisted the crashlytics domain, but it doesn't mean we can't put it in CDN policy
appendArrayInPlace(cdnDomainsList, CRASHLYTICS_WHITELIST);

return Promise.all([
new DomainsetOutput(span, 'cdn')
.withTitle('Sukka\'s Ruleset - CDN Domains')
Expand Down
62 changes: 62 additions & 0 deletions Build/constants/reject-data-source.ts
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,69 @@ export const ADGUARD_FILTERS_EXTRA: AdGuardFilterSource[] = [
]
];

// In a hostile network like when an ad blocker is present, apps might be crashing, and these errors need to be
// The reason for unblocking crashlytics is to not make developers life worse by breaking crash reporting.
// In a hostile network like when an ad blocker is present, apps might be crashing, and these errors need to be
// reported to devs, otherwise they won't learn about the issue and won't fix it.
// Also, it is not a common third-party analytics tracker, Crashlytics is not used for collecting users' data.
export const CRASHLYTICS_WHITELIST = [
// VSCode Telemetry, see https://sts.online.visualstudio.com/api/swagger/index.html
'sts.online.visualstudio.com',
// Sentry
'.ingest.sentry.io',
// bugsnag
'.sessions.bugsnag.com',
'.notify.bugsnag.com',
// influxdata
'.cloud.influxdata.com',
'.cloud1.influxdata.com',
'.cloud2.influxdata.com',
// split.io A/B flag
'streaming.split.io',
'telemetry.split.io',
'sdk.split.io',
// Google
// -ds.metric.gstatic.com are specifically exempted from reject, but it could use secondary proxy policy
'.metric.gstatic.com',
// Misc
'telemetry.1passwordservices.com',
'events.tableplus.com',
'telemetry.nextjs.org',
'telemetry.vercel.com',
'stats.setapp.com',
'stats.setapp.macpaw.dev',
'.app-analytics-services.com',
'.telemetry.services.yofi.ai',
'.cdn.pubnub.com',
'.data.debugbear.com',
'.cdn.applicationinsights.io',
'.applicationinsights.azure.com',
'.api.loganalytics.io',
'.bugly.qcloud.com',
// '.signalfx.com',
'.cdn.signalfx.com',
'.crash-reports.browser.yandex.net',
'.crashlytics2.l.google.com',
'.crashlyticsreports-pa.googleapis.com',
'.e.crashlytics.com',
'.events.backtrace.io',
'.events.split.io',
'.in.appcenter.ms',
'.loggly.com',
'.logz.io',
'.opentelemetry.io',
'.raygun.io', // dashboard lives at raygun.com
'.rum.cronitor.io',
'.settings.crashlytics.com',
'.sny.monosnap.com',
'.lr-ingest.com',
'.cdn.rollbar.com',
'.api.instabug.com',
'.ensighten.com'
];

export const PREDEFINED_WHITELIST = [
...CRASHLYTICS_WHITELIST,
'.localhost',
'.local',
'.localhost.localdomain',
Expand Down
28 changes: 0 additions & 28 deletions Source/domainset/cdn.conf
Original file line number Diff line number Diff line change
Expand Up @@ -844,34 +844,6 @@ static.agilebits.com
.cdn-lfs-us-1.huggingface.co
.cdn-lfs.huggingface.co

# >> Telemetry
# I dont mind those specifically exempted telemetry, but it definitely could use secondary proxy policy
telemetry.1passwordservices.com
.in.applicationinsights.azure.com
events.tableplus.com
telemetry.nextjs.org
telemetry.vercel.com
stats.setapp.com
stats.setapp.macpaw.dev
.app-analytics-services.com
.telemetry.services.yofi.ai
# VSCode Telemetry, see https://sts.online.visualstudio.com/api/swagger/index.html
sts.online.visualstudio.com
# Sentry
.ingest.sentry.io
# bugsnag
sessions.bugsnag.com
# influxdata
.cloud.influxdata.com
.cloud1.influxdata.com
.cloud2.influxdata.com
# split.io A/B flag
streaming.split.io
telemetry.split.io
sdk.split.io
# Google
# -ds.metric.gstatic.com are specifically exempted from reject, but it could use secondary proxy policy
.metric.gstatic.com

# >> Embed Tag / Widget
2mdn.net
Expand Down

0 comments on commit 0ca236d

Please sign in to comment.