Speed Up people_controller#index and fix spec suite #112
Conversation
I used SqlLite EXPLAIN to determine that a few tables included by `with_associations` and found a few missing indexes on `news_people` and `events_people` join tables. There doesn't seem to be a CI server set up (like Travis), so running the tests locally included upgrading a few gems, upgrading the Ruby version and changing some specs.
…adding additional tags, dynamic title based on page title), adding Twitter card tags
…nd_title_tags Facebook/Twitter social sharing tags & page titles. Closes StartupWichita#65 Thanks @lafentres 👍
|
@yez thanks for the contribution! This looks great, and I'm excited to have tests working again. |
|
Actually, it was a simple enough fix for that issue, but I found a few more once that was resolved. The date picker for Event start and stop times and the Tags field is completely gone. |
@kentonh I'm afraid I have no idea why this might be happening. My changes were limited to a migration and some spec fixes. It might have something to do with the upgrades but without real data I'm not sure how I'd diagnose that. Do you have a staging server you can put this branch up on or something to help debug? |
|
@yez Yeah, I can push it up to a new instance and share it with you there. Probs will be tomorrow, however. I think it's the Rails upgrade to 2.4.0 that causes errors with the acts_as_taggable and however the jQuery date picker. |
Addresses #111
I used SqlLite EXPLAIN to determine that a few tables included by
with_associationsand found a few missing indexes onnews_peopleandevents_peoplejoin tables.There doesn't seem to be a CI server set up (like Travis), so running
the tests locally included upgrading a few gems, upgrading the Ruby
version and changing some specs.