Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] destruct workgroup's MemTracker prematurely (backport #55134) #55158

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 16, 2025

Why I'm doing:

Fix the issue: https://github.com/StarRocks/StarRocksTest/issues/9106

wg's MemTracker is accessed from QueryContext's dtor after it is released during wg config changing, there are two cases:

  1. wg holder _wg_running_query_token_ptr is destructed before QueryContext' MemTracker.
  2. _wg_running_query_token_ptr is released prematurely when query is cancelled.
    [BugFix] Release workgroup token immediately when fragment is cancelled #19310

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@wanpengfei-git wanpengfei-git merged commit 86c4814 into branch-3.2 Jan 16, 2025
36 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-55134 branch January 16, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants