CVE TEST #53306
Open
CVE TEST #53306
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andyziye <[email protected]>
Signed-off-by: andyziye <[email protected]>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| } | ||
| } | ||
| return filedToMetricsMode; | ||
|
|
||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
The most risky bug in this code is:
The filedToMetricsMode map uses incorrect spelling for its variable name, which may lead to confusion and errors elsewhere in the code if it is referenced incorrectly as fieldToMetricsMode.
You can modify the code like this:
Map<String, MetricsModes.MetricsMode> fieldToMetricsMode = Maps.newHashMap();
for (Types.NestedField field : table.getNativeTable().schema().columns()) {
MetricsModes.MetricsMode mode = metricsConf.columnMode(field.name());
// To reduce printing, only print specific metrics that are not in the
// DEFAULT_WRITE_METRICS_MODE_DEFAULT: truncate(16) mode
if (!mode.equals(defaultMode)) {
fieldToMetricsMode.put(field.name(), mode);
}
}
return fieldToMetricsMode;
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Signed-off-by: andyziye <[email protected]>
Signed-off-by: andyziye <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: