[Enhancement] Compare mv rowCount when both mv dimensions contains query dimensions (backport #51511) #53305
+39
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Before: prefer mv with less dimensions -> mv2, but mv2 has more rows which is not expected.
After: when many mvs satisfy query, prefer mv with less rows, so choose mv1.
What I'm doing:
MaterializationContext.RewriteOrdering
decides which MVs are retained in case too many MV candidates and candidate list should be truncated.MaterializationContext.RewriteOrdering
should compare MV's maxPartitionRowCount rather than MV's total row count, in case a MV is with less partitions and total row count but maxPartitionRowCount is large.BestMvSelector
is the actually place to decide which MV should be chose. The comparator inBestMvSelector
should consider row count first if MV's outputRowCount is not zero in statistics.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #51511 done by [Mergify](https://mergify.com). ## Why I'm doing:
Before: prefer mv with less dimensions -> mv2, but mv2 has more rows which is not expected.
After: when many mvs satisfy query, prefer mv with less rows, so choose mv1.
What I'm doing:
MaterializationContext.RewriteOrdering
decides which MVs are retained in case too many MV candidates and candidate list should be truncated.MaterializationContext.RewriteOrdering
should compare MV's maxPartitionRowCount rather than MV's total row count, in case a MV is with less partitions and total row count but maxPartitionRowCount is large.BestMvSelector
is the actually place to decide which MV should be chose. The comparator inBestMvSelector
should consider row count first if MV's outputRowCount is not zero in statistics.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
Checklist: