[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLog` #45933

starrocks-xupeng · 2024-05-20T09:16:48Z

Why I'm doing:

What I'm doing:

do not check whether global state mgr is leader when writes star mgr's journal

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: starrocks-xupeng <[email protected]>

sonarcloud · 2024-05-20T12:21:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-05-20T14:10:22Z

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/persist/EditLog.java	1	1	100.00%	[]

github-actions · 2024-05-20T14:11:00Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-05-21T02:15:02Z

@Mergifyio backport branch-3.3

github-actions · 2024-05-21T02:15:04Z

@Mergifyio backport branch-3.2

github-actions · 2024-05-21T02:15:05Z

@Mergifyio backport branch-3.1

mergify · 2024-05-21T02:15:12Z

backport branch-3.3

✅ Backports have been created

#45958 [BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog (backport #45933) has been created for branch branch-3.3

mergify · 2024-05-21T02:15:13Z

backport branch-3.2

✅ Backports have been created

#45959 [BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog (backport #45933) has been created for branch branch-3.2 but encountered conflicts

mergify · 2024-05-21T02:15:14Z

backport branch-3.1

✅ Backports have been created

#45960 [BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog (backport #45933) has been created for branch branch-3.1 but encountered conflicts

…g` (#45933) Signed-off-by: starrocks-xupeng <[email protected]> (cherry picked from commit 95b551d)

…g` (#45933) Signed-off-by: starrocks-xupeng <[email protected]> (cherry picked from commit 95b551d) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/persist/EditLog.java

…g` (backport StarRocks#45933) Signed-off-by: starrocks-xupeng <[email protected]>

starrocks-xupeng · 2024-05-21T02:59:04Z

#45968, branch-3.2

starrocks-xupeng · 2024-05-21T02:59:17Z

#45962, branch-3.1

…g` (backport #45933) (#45968) Signed-off-by: starrocks-xupeng <[email protected]>

…g` (backport #45933) (#45962) Signed-off-by: starrocks-xupeng <[email protected]>

…g` (backport #45933) (#45958) Co-authored-by: starrocks-xupeng <[email protected]>

starrocks-xupeng requested a review from a team as a code owner May 20, 2024 09:16

wanpengfei-git added the META-REVIEW label May 20, 2024

wanpengfei-git requested a review from a team May 20, 2024 09:17

mergify bot assigned starrocks-xupeng May 20, 2024

nshangyiming previously approved these changes May 20, 2024

View reviewed changes

github-actions bot added 3.3 3.2 3.1 labels May 20, 2024

starrocks-xupeng dismissed nshangyiming’s stale review via 1334616 May 20, 2024 09:24

starrocks-xupeng force-pushed the log_fix branch from a096b11 to 1334616 Compare May 20, 2024 09:24

nshangyiming previously approved these changes May 20, 2024

View reviewed changes

starrocks-xupeng dismissed nshangyiming’s stale review via fa38704 May 20, 2024 09:30

starrocks-xupeng force-pushed the log_fix branch from 1334616 to fa38704 Compare May 20, 2024 09:30

kevincai approved these changes May 20, 2024

View reviewed changes

[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog

9355eeb

Signed-off-by: starrocks-xupeng <[email protected]>

starrocks-xupeng force-pushed the log_fix branch from fa38704 to 9355eeb Compare May 20, 2024 11:21

nshangyiming approved these changes May 21, 2024

View reviewed changes

nshangyiming merged commit 95b551d into StarRocks:main May 21, 2024
44 checks passed

github-actions bot removed the 3.3 label May 21, 2024

github-actions bot removed the 3.2 label May 21, 2024

github-actions bot removed the 3.1 label May 21, 2024

mergify bot pushed a commit that referenced this pull request May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLo…

402b2c8

…g` (#45933) Signed-off-by: starrocks-xupeng <[email protected]> (cherry picked from commit 95b551d)

mergify bot mentioned this pull request May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog (backport #45933) #45958

Merged

42 tasks

mergify bot mentioned this pull request May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog (backport #45933) #45959

Closed

42 tasks

mergify bot mentioned this pull request May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog (backport #45933) #45960

Closed

42 tasks

github-actions bot added 3.2 3.1 labels May 21, 2024

starrocks-xupeng added a commit to starrocks-xupeng/starrocks that referenced this pull request May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLo…

75bc1a3

…g` (backport StarRocks#45933) Signed-off-by: starrocks-xupeng <[email protected]>

nshangyiming pushed a commit that referenced this pull request May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLo…

d2ee773

…g` (backport #45933) (#45968) Signed-off-by: starrocks-xupeng <[email protected]>

github-actions bot added the 3.2-merged label May 21, 2024

nshangyiming pushed a commit that referenced this pull request May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLo…

328a85f

…g` (backport #45933) (#45962) Signed-off-by: starrocks-xupeng <[email protected]>

wanpengfei-git pushed a commit that referenced this pull request May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLo…

6f24e87

…g` (backport #45933) (#45958) Co-authored-by: starrocks-xupeng <[email protected]>

github-actions bot added 3.1-merged 3.3-merged labels May 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLog` #45933

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLog` #45933

starrocks-xupeng commented May 20, 2024 •

edited

sonarcloud bot commented May 20, 2024

github-actions bot commented May 20, 2024

github-actions bot commented May 20, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

mergify bot commented May 21, 2024 •

edited

mergify bot commented May 21, 2024 •

edited

mergify bot commented May 21, 2024 •

edited

starrocks-xupeng commented May 21, 2024 •

edited

starrocks-xupeng commented May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog #45933

[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog #45933

Conversation

starrocks-xupeng commented May 20, 2024 • edited

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarcloud bot commented May 20, 2024

Quality Gate passed

github-actions bot commented May 20, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented May 20, 2024

[BE Incremental Coverage Report]

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

mergify bot commented May 21, 2024 • edited

✅ Backports have been created

mergify bot commented May 21, 2024 • edited

✅ Backports have been created

mergify bot commented May 21, 2024 • edited

✅ Backports have been created

starrocks-xupeng commented May 21, 2024 • edited

starrocks-xupeng commented May 21, 2024

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLog` #45933

[BugFix] ignore star mgr's OP_STARMGR journal write only in `submitLog` #45933

starrocks-xupeng commented May 20, 2024 •

edited

mergify bot commented May 21, 2024 •

edited

mergify bot commented May 21, 2024 •

edited

mergify bot commented May 21, 2024 •

edited

starrocks-xupeng commented May 21, 2024 •

edited