Fix TypeError in help command by handling mixed parameter types for sorting #6266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses the issue where the
st2 run action pack.action -h
command fails with aTypeError: '<' not supported between instances of 'str' and 'int'
. The error occurs when sorting action parameters that have a mix of names (strings) and positions (integers). In Python 3, comparing these types directly causes a failure.Root Cause:
The sorting function attempts to sort action parameters by either the
position
attribute (if present) or thename
. In some cases,position
is an integer whilename
is a string, leading to a type comparison error in Python 3.Fix:
The
_get_parameter_sort_value
method has been updated to:position
attribute to a string (if it exists) for consistent sorting.name
whenposition
is not available.Fixes #5130