Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kssteven418 , thanks for this brilliant quantization framework and great results .
This is an effort to add a SYCL backend to Squeezellm. We are currently validating the performance on Intel hardware, and SYCL for Cuda backend as well.
For the python api side , I am thinking of a better design pattern to segregate XPU(Intel) device logic. While the SYCL kernels are compatible with Nvidia hardware , we are testing equivalent performance results on both devices on SYCL runtime.
Appreciate your reviews and feedbacks.