Merge pull request #3 from Space48/feature/remove-environment-checking

Remove environment checking on command execution
Space48 · May 4, 2018 · 8668d9f · 8668d9f
2 parents d7a8259 + 2e485d6
commit 8668d9f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 22 deletions.
diff --git a/src/ConfigValueSet.php b/src/ConfigValueSet.php
@@ -52,4 +52,9 @@ public static function create(): self
     private function __construct()
     {
     }
+
+    public function isEmpty(): bool
+    {
+        return empty($this->values);
+    }
 }
diff --git a/src/EnvironmentConfigurationCommand.php b/src/EnvironmentConfigurationCommand.php
@@ -43,15 +43,6 @@ protected function configure()
     public function execute(InputInterface $input, OutputInterface $output)
     {
         $environment = $input->getArgument('environment');
-
-        if (!Environment::isValid($environment)) {
-            throw new \InvalidArgumentException(sprintf(
-                'Specified environment %s is invalid, accepted environments are %s.',
-                $environment,
-                implode(', ', Environment::all())
-            ));
-        }
-
         $environmentValues = $this
             ->environmentConfigValuesProvider
             ->getValues()
@@ -62,10 +53,16 @@ public function execute(InputInterface $input, OutputInterface $output)
             $this->configValueRepository->save($configValue);
         }
 
-        $output->writeln(sprintf(
-            'Updated config values for environment %s',
-            $environment)
-        );
+        if ($environmentValues->isEmpty()) {
+            $output->writeln('No configuration found for environment ' . $environment);
+        } else {
+            $output->writeln(sprintf(
+                'Updated config values for environment %s',
+                $environment
+            ));
+        }
+
+
 
         return 0;
     }

diff --git a/test/EnvironmentConfigurationCommandTest.php b/test/EnvironmentConfigurationCommandTest.php
@@ -18,15 +18,6 @@ class EnvironmentConfigurationCommandTest extends TestCase
     /** @var EnvironmentConfigurationCommand */
     private $subject;
 
-    public function testExecuteFailure()
-    {
-        $input = $this->getMockForAbstractClass(InputInterface::class);
-        $output = $this->getMockForAbstractClass(OutputInterface::class);
-
-        $this->expectException(\InvalidArgumentException::class);
-        $this->subject->execute($input, $output);
-    }
-
     public function testExecuteSuccess()
     {
         $input = $this->getMockForAbstractClass(InputInterface::class);