Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLCORE-765 Log uncaught notification handling errors #988

Conversation

damien-urruty-sonarsource
Copy link
Contributor

No description provided.

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the fix/dam/SLCORE-765-log-uncaught-client-errors branch 2 times, most recently from 63a32e4 to 7d578dd Compare May 17, 2024 09:42
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the fix/dam/SLCORE-765-log-uncaught-client-errors branch 2 times, most recently from ae76a97 to 8be7707 Compare May 17, 2024 10:07
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! LGTM. I just added a minor simplification in the test.

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the fix/dam/SLCORE-765-log-uncaught-client-errors branch from 8be7707 to 30a13d6 Compare May 17, 2024 13:56
@damien-urruty-sonarsource damien-urruty-sonarsource merged commit b2e5ee6 into master May 17, 2024
12 checks passed
@damien-urruty-sonarsource damien-urruty-sonarsource deleted the fix/dam/SLCORE-765-log-uncaught-client-errors branch May 17, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants