Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null pointer access when HTTP host is unreachable #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix null pointer access when HTTP host is unreachable #595

wants to merge 1 commit into from

Conversation

jblievremont
Copy link
Member

No description provided.

henryju
henryju reviewed May 4, 2023
View reviewed changes
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it something you can reproduce in a test? Since we are gonna refactor the HTTP client, I would like to avoid regressions later.

@jblievremont
Copy link
Member Author

I'll try to add a test, it's something we observed in SLLS unit tests.

@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@nquinquenel
Copy link
Member

This is something I also noticed, and I made a modification on the HTTP client PR, LGTM 👍

@damien-urruty-sonarsource
Copy link
Contributor

This PR is opened for a long time, what should we do with it? I never encountered this error myself, is it fixed with what you mentioned Nicolas? If so, then we can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryju henryju henryju left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jblievremont @nquinquenel @damien-urruty-sonarsource @henryju