Feature/add recommended warning configuration #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andreasgoodstein, I really need this setup, do you know why this is not merged? |
@marcoahansen sadly I don't know. I'm not a maintainer of this repo, so without feedback/approval from them there is nothing I can do... |
|
hello, I believe such a configuration should be done in the place where plugin is used. We don't want to maintain additional config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #166, resolves #283
This PR adds the 'recommended-warn' configuration to the plugin, which enables all recommended rules with severity 'warn'. I've also added a test case and updated the docs to reflect the change. Let me know if any additional changes should be made.
Thanks for an amazing plugin. Cheers.