Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: running with Node.js 22 #1665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohd-akram
Copy link
Contributor

@mohd-akram mohd-akram commented May 19, 2024

Resolves SyntaxError: Unexpected identifier 'assert' in Node.js 22.

Closes #1663

@dziraf
Copy link
Contributor

dziraf commented May 21, 2024

Changing the import syntax is not enough, there are extra changes to Babel required + the last time I checked TS highlighted with as an error even though we're already at v5.3+ so it'd be the best to update typescript too.

@mohd-akram
Copy link
Contributor Author

mohd-akram commented May 21, 2024

Thanks, that helped.

Babel was converting it to with type: 'json' (I believe that's the with-legacy option).

Support for import attributes was added in Node.js 18.20 so the CI version needed to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Use import specifier 'with' instead of 'assert'
2 participants