Smem str constants #501
Draft
Smem str constants #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 5, 2024 09:05
|
The only reason I'm not moving forward immediately is because I have yet to write a unit test. the author has already provided a working example that could be used for such -- it just needs to be put into the unit test framework. Otherwise, I've built the code locally, played a little with it, and it seems to make sense (having read the changes line by line.) |
|
Any documentation changes required as follow-up? The manual, perhaps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to add LTIs via a string alias that persists across add commands. A new table stores the aliases.