Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AContainer can't find recipes with similar items #4177

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix AContainer can't find recipes with similar items #4177

wants to merge 9 commits into from

Conversation

JWJUN233233
Copy link
Contributor

@JWJUN233233 JWJUN233233 commented Apr 27, 2024 •
edited

Description

#4166

Proposed changes

Related Issues (if applicable)

#4166

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@JWJUN233233 JWJUN233233 requested a review from a team as a code owner April 27, 2024 07:32
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Apr 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@JustAHuman-xD
Copy link
Contributor

Can you update the PR to be inline with the code style guidelines

@JWJUN233233 JWJUN233233 mentioned this pull request Apr 27, 2024
Closed
7 tasks
@JWJUN233233
Copy link
Contributor Author

i wonder whats wrong with my codestyle

@lijinhong11 lijinhong11 mentioned this pull request May 3, 2024
Open
4 tasks
@Intybyte
Copy link

Intybyte commented May 4, 2024

i wonder whats wrong with my codestyle

Don't use wildcard(*) imports.
Don't use functional methods like .stream() or .foreach( x -> ...), just use a normal for loop.
Saving x and y Inputs in a variable would help with readibility.

@J3fftw1
Copy link
Member

J3fftw1 commented May 4, 2024

Variables need to be camel_Case

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 4, 2024 •
edited

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 505b444

https://preview-builds.walshy.dev/download/Slimefun/4177/505b4442

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

J3fftw1
J3fftw1 requested changes May 4, 2024
View reviewed changes
Copy link
Member

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stay consistend.

On some places you spam 1 liners.
on some places you do braces around the if statement.

src/main/java/io/github/thebusybiscuit/slimefun4/utils/ItemUtils.java Outdated Show resolved Hide resolved
src/main/java/me/mrCookieSlime/Slimefun/Objects/SlimefunItem/abstractItems/AContainer.java Outdated Show resolved Hide resolved
src/main/java/me/mrCookieSlime/Slimefun/Objects/SlimefunItem/abstractItems/AContainer.java Outdated Show resolved Hide resolved
src/main/java/me/mrCookieSlime/Slimefun/Objects/SlimefunItem/abstractItems/AContainer.java Show resolved Hide resolved
src/main/java/me/mrCookieSlime/Slimefun/Objects/SlimefunItem/abstractItems/AContainer.java Outdated Show resolved Hide resolved
src/main/java/me/mrCookieSlime/Slimefun/Objects/SlimefunItem/abstractItems/AContainer.java Outdated Show resolved Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/utils/ItemUtils.java Outdated Show resolved Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/utils/ItemUtils.java Outdated Show resolved Hide resolved
@J3fftw1
Copy link
Member

J3fftw1 commented May 4, 2024

Thanks for the first PR we really appreciate it.

JWJUN233233 and others added 7 commits May 4, 2024 19:22
@JWJUN233233 @J3fftw1
codestyle - 1
93cd9bb 
Co-authored-by: J3fftw <[email protected]>
@JWJUN233233 @J3fftw1
codestyle - 2
d5d82ea 
Co-authored-by: J3fftw <[email protected]>
@JWJUN233233 @J3fftw1
codestyle - 3
ad64468 
Co-authored-by: J3fftw <[email protected]>
@JWJUN233233 @J3fftw1
codestyle - 4
18940e9 
Co-authored-by: J3fftw <[email protected]>
@JWJUN233233 @J3fftw1
codestyle - 5
07ceb01 
Co-authored-by: J3fftw <[email protected]>
@JWJUN233233
improve my codes
e00e410
@JWJUN233233 @J3fftw1
codestyle - 6
ad8f0b6 
Co-authored-by: J3fftw <[email protected]>
@JWJUN233233 JWJUN233233 requested a review from J3fftw1 May 4, 2024 11:33
@JustAHuman-xD JustAHuman-xD added the 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. label May 4, 2024
@JustAHuman-xD
Copy link
Contributor

Don't we have an item utils already or something like it?

@JWJUN233233
Copy link
Contributor Author

Don't we have an item utils already or something like it?

It seems not

@lijinhong11
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J3fftw1 J3fftw1 Awaiting requested review from J3fftw1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
✨ Fix This Pull Request fixes an issue. 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JWJUN233233 @JustAHuman-xD @Intybyte @J3fftw1 @lijinhong11