BUG: Mark translatable strings in module ExtensionWizard #7698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
reviewed
Apr 16, 2024
| @@ -12,7 +12,7 @@ | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
|
|
|||
| This file was originally developed by Adam Rankin, PerkLab, Queen's University | |||
| This file was originally developed by Adam Rankin, PerkLab, Queen's University | |||
| @@ -186,7 +189,7 @@ def setupTemplates(self): | |||
| try: | |||
| self.templateManager.addPath(builtinPath) | |||
| except: | |||
| qt.qWarning("failed to add built-in template path %r" % builtinPath) | |||
| qt.qWarning(_("failed to add built-in template {path} %r") % builtinPath) | |||
There was a problem hiding this comment.
Suggested change
| qt.qWarning(_("failed to add built-in template {path} %r") % builtinPath) | |
| qt.qWarning(_("failed to add built-in template {path}").format(path=builtinPath)) |
| @@ -195,7 +198,7 @@ def setupTemplates(self): | |||
| try: | |||
| self.templateManager.addPath(path) | |||
| except: | |||
| qt.qWarning("failed to add template path %r" % path) | |||
| qt.qWarning(_("failed to add template {path} %r") % path) | |||
There was a problem hiding this comment.
fix the same way as the previous one
| @@ -206,13 +209,13 @@ def setupTemplates(self): | |||
| self.templateManager.addCategoryPath(c, path) | |||
| except: | |||
| mp = (c, path) | |||
| qt.qWarning("failed to add template path %r for category %r" % mp) | |||
| qt.qWarning(_("failed to add template path %r for category %r") % mp) | |||
There was a problem hiding this comment.
fix the same way as the previous one
| dlg = CreateComponentDialog("extension", self.parent.window()) | ||
| dlg.setTemplates(self.templateManager.templates("extensions")) | ||
| dlg = CreateComponentDialog(_("extension"), self.parent.window()) | ||
| dlg.setTemplates(self.templateManager.templates(_("extensions"))) |
There was a problem hiding this comment.
I don't think is is allowed to be translated. Please test.
Suggested change
| dlg.setTemplates(self.templateManager.templates(_("extensions"))) | |
| dlg.setTemplates(self.templateManager.templates("extensions")) |
| dlg.setTemplates(self.templateManager.templates("modules"), | ||
| default="scripted") | ||
| dlg = CreateComponentDialog(_("module"), self.parent.window()) | ||
| dlg.setTemplates(self.templateManager.templates(_("modules")), |
There was a problem hiding this comment.
probably must not be translated, please test
| default="scripted") | ||
| dlg = CreateComponentDialog(_("module"), self.parent.window()) | ||
| dlg.setTemplates(self.templateManager.templates(_("modules")), | ||
| default=_("scripted")) |
There was a problem hiding this comment.
probably must not be translated
| dlg.showDestination = False | ||
|
|
||
| while dlg.exec_() == qt.QDialog.Accepted: | ||
| name = dlg.componentName | ||
|
|
||
| try: | ||
| self.templateManager.copyTemplate(self.extensionLocation, "modules", | ||
| self.templateManager.copyTemplate(self.extensionLocation, _("modules"), |
There was a problem hiding this comment.
probably must not be translated
| project = _map_property(lambda self: self.ui.nameEdit, "text") | ||
| category = _map_property(lambda self: self.ui.categoryEdit, "text") | ||
| description = _map_property(lambda self: self.ui.descriptionEdit, "plainText") | ||
| project = _map_property(lambda self: self.ui.nameEdit, _("text")) |
There was a problem hiding this comment.
"text" must not be translated in these lines (this is a Qt object property name)
| @@ -113,7 +114,7 @@ def contributors(self, value): | |||
| item.setText(1, c[n + 1 : -1].strip()) | |||
|
|
|||
| except ValueError: | |||
| qt.qWarning("%r: badly formatted contributor" % c) | |||
| qt.qWarning(_("%r: badly formatted contributor") % c) | |||
MohamedAllali
added a commit
to MohamedAllali/Slicer
that referenced
this pull request
May 21, 2024
lassoan
approved these changes
Jun 1, 2024
|
Ok, done. thank you Mr. @lassoan . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lassoan can you please look at this.