Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wnarrowing on raspberry pi #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Aug 20, 2022

  1. fix(net_socket): compare ans with NULL to check failed inet_ntop() call

    In getAddressAsString(), we are comparing ans <=  0 to check for failure. When compiling with g++ 11.2 (Ubuntu 22.02), this gave the following error:
    
    src/arch/linux/net_socket.cpp:170:15: error: ordered comparison of pointer with integer zero (‘const char*’ and ‘int’)
    
    inet_ntop returns a NULL pointer for failure and non-NULL otherwise. So in order to fix this, we can simply compare ans with NULL.
    vitsensei committed Aug 20, 2022
    Configuration menu
    Copy the full SHA
    1932882 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. fix(driver): Wnarrowing flag create compile error on Raspberry pi

    A simple static cast seems to do the trick.
    warrenbocphet committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b4776b4 View commit details
    Browse the repository at this point in the history