Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMAKE, linux/macos build. Updated for new versions #132

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Marcus-Forte
Copy link

Based on @warrenbocphet

warrenbocphet and others added 6 commits September 15, 2022 13:47
* fix(net_socket): compare ans with NULL to check failed inet_ntop() call

In getAddressAsString(), we are comparing ans <=  0 to check for failure. When compiling with g++ 11.2 (Ubuntu 22.02), this gave the following error:

src/arch/linux/net_socket.cpp:170:15: error: ordered comparison of pointer with integer zero (‘const char*’ and ‘int’)

inet_ntop returns a NULL pointer for failure and non-NULL otherwise. So in order to fix this, we can simply compare ans with NULL.

* add CMake support

* play around with exporting config

* fix up cmake

Co-authored-by: vitsensei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants