Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scalable ch player arrow #521

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

feat: scalable ch player arrow #521

wants to merge 10 commits into from

Conversation

Kemmisch
Copy link
Contributor

make ch player arrow scalable through a config option

@Kemmisch
feat: scalable ch player arrow
10e1971 
make ch player arrow scalable
My-Name-Is-Jeff
My-Name-Is-Jeff requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@My-Name-Is-Jeff My-Name-Is-Jeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also put it in the translation file

src/main/kotlin/gg/skytils/skytilsmod/core/Config.kt Outdated Show resolved Hide resolved
@Kemmisch
Update Config.kt
7f4d6a4 
spelling & translation

Signed-off-by: songreaver  <[email protected]>
@Kemmisch
Update CHWaypoints.kt
57b37eb 
fix scaling numbers

Signed-off-by: songreaver  <[email protected]>
@Kemmisch
Copy link
Contributor Author

Kemmisch commented Nov 3, 2024 •
edited
Loading

also put it in the translation file

should i leave CN & TW blank, or leave the english in there?

@Kemmisch
Update en_US.lang
7d7b55d 
Signed-off-by: songreaver  <[email protected]>
@Kemmisch
Update Config.kt
4d3de5e 
move scale up and make dependent on map

Signed-off-by: songreaver  <[email protected]>
@My-Name-Is-Jeff
Copy link
Member

also put it in the translation file

should i leave CN & TW blank, or leave the english in there?

You can just leave it blank I believe and it should default to English

Kemmisch and others added 5 commits November 6, 2024 18:38
@Kemmisch @My-Name-Is-Jeff
Apply suggestions from code review
d7be632 
Co-authored-by: My-Name-Is-Jeff <[email protected]>
Signed-off-by: songreaver  <[email protected]>
@Kemmisch
Update zh_CN.lang
39da68c 
Signed-off-by: songreaver  <[email protected]>
@Kemmisch
Update zh_TW.lang
d079951 
Signed-off-by: songreaver  <[email protected]>
@Kemmisch
Update zh_TW.lang
84b0db8 
oops missed an s

Signed-off-by: songreaver  <[email protected]>
@Kemmisch
Update zh_CN.lang
52bca6b 
ok apparently i forgot twice?

Signed-off-by: songreaver  <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@My-Name-Is-Jeff My-Name-Is-Jeff Awaiting requested review from My-Name-Is-Jeff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kemmisch @My-Name-Is-Jeff